From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932460AbaHGOXy (ORCPT ); Thu, 7 Aug 2014 10:23:54 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:59595 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbaHGOXw (ORCPT ); Thu, 7 Aug 2014 10:23:52 -0400 Date: Thu, 7 Aug 2014 16:23:46 +0200 From: Thierry Reding To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, ajitpal.singh@st.com Subject: Re: [PATCH v2 06/11] pwm: sti: Add new driver for ST's PWM IP Message-ID: <20140807142344.GA11095@ulmo.nvidia.com> References: <1405348412-7352-1-git-send-email-lee.jones@linaro.org> <1405348412-7352-7-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1405348412-7352-7-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 14, 2014 at 03:33:27PM +0100, Lee Jones wrote: [...] > +static int sti_pwm_probe(struct platform_device *pdev) > +{ [...] > + pc->clk = of_clk_get_by_name(np, "pwm"); This didn't compile because the np variable isn't declared. It was easy to fix up, so I did, but please be more careful next time that the patches you submit at least compile (preferably without sparse warnings of which I also fixed up a couple). Thierry --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT44vwAAoJEN0jrNd/PrOhpFoQAJwqmsIk7noDjJTpYqAUBCpp xYopvk4EtZfEe9Fl8yzDTr8oRC1wyijP72PmdKUO1D33gPqgiNqPn33ky4OwOK/U pMqjlUioZPU8dVWjVewy3f/XCRFtedkIw9mu9v50i2grORY18yYVmuas/O2RoRG/ /dJVZyP0GqrcaKfstpiTuxtDpMeucpdMFd1ppRvA5LBmdSvdun6qaTcqXrfUwbVN QzNxTB/QkOlezA5qSvKHkIPRigDrpb+zCNmfWj8pcG2pDz6vKwHukAZ1/rXf+Ww1 laPwQ3/Cke/IYx78+wdUtbBbooTRZcZBqdMLpAxHPqnGQUOb23CLXNdDkGjBFPUk MmOpUob3vg4cF8vzuivwDc4K/TMwU6Zmxf/nSeUDCca6uD7BjyWQS21nRkwOz7ob Fobr4n16kSt9jEgAe1g1VowrKI4mla4t2ngRJXH2V5rzeoO9rpGrbi67a04bV/MV RMMv6Gr2iuslR6+re8uALuX0JLxBqdT02i9pibWkCuJJLoMRMqkS2F1LJ1CfyAq2 ucs9UErC57Jfh4m3UYn9c9meeUF7K+5oyPuuRvTA1csVLnStC5WEb7+PEJzuHLBA 22KzbCGXUg+Fq8FZS8VWaW5kCVsSsg0A3nvSYcFkPiBlV4MTz9HJysNtkIAMUn6x OeT8S/WhocGLv7BHYjCv =0kUt -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 06/11] pwm: sti: Add new driver for ST's PWM IP Date: Thu, 7 Aug 2014 16:23:46 +0200 Message-ID: <20140807142344.GA11095@ulmo.nvidia.com> References: <1405348412-7352-1-git-send-email-lee.jones@linaro.org> <1405348412-7352-7-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Return-path: Content-Disposition: inline In-Reply-To: <1405348412-7352-7-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ajitpal.singh-qxv4g6HH51o@public.gmane.org List-Id: devicetree@vger.kernel.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 14, 2014 at 03:33:27PM +0100, Lee Jones wrote: [...] > +static int sti_pwm_probe(struct platform_device *pdev) > +{ [...] > + pc->clk = of_clk_get_by_name(np, "pwm"); This didn't compile because the np variable isn't declared. It was easy to fix up, so I did, but please be more careful next time that the patches you submit at least compile (preferably without sparse warnings of which I also fixed up a couple). Thierry --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT44vwAAoJEN0jrNd/PrOhpFoQAJwqmsIk7noDjJTpYqAUBCpp xYopvk4EtZfEe9Fl8yzDTr8oRC1wyijP72PmdKUO1D33gPqgiNqPn33ky4OwOK/U pMqjlUioZPU8dVWjVewy3f/XCRFtedkIw9mu9v50i2grORY18yYVmuas/O2RoRG/ /dJVZyP0GqrcaKfstpiTuxtDpMeucpdMFd1ppRvA5LBmdSvdun6qaTcqXrfUwbVN QzNxTB/QkOlezA5qSvKHkIPRigDrpb+zCNmfWj8pcG2pDz6vKwHukAZ1/rXf+Ww1 laPwQ3/Cke/IYx78+wdUtbBbooTRZcZBqdMLpAxHPqnGQUOb23CLXNdDkGjBFPUk MmOpUob3vg4cF8vzuivwDc4K/TMwU6Zmxf/nSeUDCca6uD7BjyWQS21nRkwOz7ob Fobr4n16kSt9jEgAe1g1VowrKI4mla4t2ngRJXH2V5rzeoO9rpGrbi67a04bV/MV RMMv6Gr2iuslR6+re8uALuX0JLxBqdT02i9pibWkCuJJLoMRMqkS2F1LJ1CfyAq2 ucs9UErC57Jfh4m3UYn9c9meeUF7K+5oyPuuRvTA1csVLnStC5WEb7+PEJzuHLBA 22KzbCGXUg+Fq8FZS8VWaW5kCVsSsg0A3nvSYcFkPiBlV4MTz9HJysNtkIAMUn6x OeT8S/WhocGLv7BHYjCv =0kUt -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Thu, 7 Aug 2014 16:23:46 +0200 Subject: [PATCH v2 06/11] pwm: sti: Add new driver for ST's PWM IP In-Reply-To: <1405348412-7352-7-git-send-email-lee.jones@linaro.org> References: <1405348412-7352-1-git-send-email-lee.jones@linaro.org> <1405348412-7352-7-git-send-email-lee.jones@linaro.org> Message-ID: <20140807142344.GA11095@ulmo.nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 14, 2014 at 03:33:27PM +0100, Lee Jones wrote: [...] > +static int sti_pwm_probe(struct platform_device *pdev) > +{ [...] > + pc->clk = of_clk_get_by_name(np, "pwm"); This didn't compile because the np variable isn't declared. It was easy to fix up, so I did, but please be more careful next time that the patches you submit at least compile (preferably without sparse warnings of which I also fixed up a couple). Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: