From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932949AbaHGR3S (ORCPT ); Thu, 7 Aug 2014 13:29:18 -0400 Received: from casper.infradead.org ([85.118.1.10]:48125 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082AbaHGR3O (ORCPT ); Thu, 7 Aug 2014 13:29:14 -0400 Date: Thu, 7 Aug 2014 19:29:01 +0200 From: Peter Zijlstra To: chas williams - CONTRACTOR Cc: Fengguang Wu , netdev@vger.kernel.org, LKML , lkp@01.org, linux-atm-general@lists.sourceforge.net Subject: Re: [setsockopt] WARNING: CPU: 0 PID: 1444 at kernel/sched/core.c:7088 __might_sleep+0x51/0x16f() Message-ID: <20140807172901.GH3588@twins.programming.kicks-ass.net> References: <20140805214624.GA9973@localhost> <20140807151741.GP19379@twins.programming.kicks-ass.net> <20140807125948.2b7f1472@thirdoffive.cmf.nrl.navy.mil> <20140807172514.GY9918@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ca0e2zgpnh8/XhnM" Content-Disposition: inline In-Reply-To: <20140807172514.GY9918@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ca0e2zgpnh8/XhnM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 07, 2014 at 07:25:14PM +0200, Peter Zijlstra wrote: > > This isn't the only place that we queue a message for the signalling > > daemon after a prepare_to_wait() uninterruptibly so this patch would > > be incomplete as is. >=20 > I'm not sure I follow, this is the only place you do so while then going > to sleep. All other sites don't sleep while they're enqueued on the > waitqueue. Argh, my brain is fried, you're quite right. I'll go have another stab at it tomorrow or so. --Ca0e2zgpnh8/XhnM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJT47ddAAoJEHZH4aRLwOS6IJYP/AgnaGHDuGXI2z1rZGgIWO0e pIDb2KDWni3pMhFMX5cqHGUR9GwTSJarQa0TUrzHvxIxgOznqij+N39uFDU+5VLV 5rr1CRzyOCCHRAP4hr8H0T6LkTResh2gbjE4EOEvZvlfFfYwjGwxNZmghzrMVcvG vJYRtGWU1PM4Ge3WUIFIgEEtLTlkrFowBxclsiBG5fhBMGjzUICaWs8ot+Xpni98 s6EqE1VNnFPjJ4vvj6CiHlX/40b3bTB04IoxMEFAf3/BcYS41c1EQ3q0eKgr86+O hI3InH7/VWK/A9A/Q99In55nLQr/ZCVVCtFOL0QJA/2QOtNgacZKuPZyg84OnHHN ZHGPA2YkQhL0xL3oAgKqka2quFuA0FA18VQjkvUpTWltEu/BMLp0S/pns/GDenBi YkIRrJuK+bDG0KD97XNGPeRXo903BxIcuBESslp+KbC6/70WdvbIcU4q/mJvuHfV xW2ujDYyVf+PROsTpf3SFtWMbfzAClMrh6X2wx69VigNfQQwl2NFXpP36IzXHtfr 7ihxVFwxhBNvkRszqkYlBg2jiluXIcHbTCnrrUn6gkP2o2qn1pmZ+WaRZU7sUW06 EY29KFtGjvWrZCQfpp2TriAO20bpsw8m9lHe7TWYaF9194A7VHsivuufsXeKjflz VN5tug3v9HQCYvhaxh9O =Xt9h -----END PGP SIGNATURE----- --Ca0e2zgpnh8/XhnM-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5909051313222103364==" MIME-Version: 1.0 From: Peter Zijlstra To: lkp@lists.01.org Subject: Re: [setsockopt] WARNING: CPU: 0 PID: 1444 at kernel/sched/core.c:7088 __might_sleep+0x51/0x16f() Date: Thu, 07 Aug 2014 19:29:01 +0200 Message-ID: <20140807172901.GH3588@twins.programming.kicks-ass.net> In-Reply-To: <20140807172514.GY9918@twins.programming.kicks-ass.net> List-Id: --===============5909051313222103364== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Aug 07, 2014 at 07:25:14PM +0200, Peter Zijlstra wrote: > > This isn't the only place that we queue a message for the signalling > > daemon after a prepare_to_wait() uninterruptibly so this patch would > > be incomplete as is. > = > I'm not sure I follow, this is the only place you do so while then going > to sleep. All other sites don't sleep while they're enqueued on the > waitqueue. Argh, my brain is fried, you're quite right. I'll go have another stab at it tomorrow or so. --===============5909051313222103364== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.sig" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC4xMiAoR05V L0xpbnV4KQoKaVFJY0JBRUJBZ0FHQlFKVDQ3ZGRBQW9KRUhaSDRhUkx3T1M2SUpZUC9BZ25hR0hE dUdYSTJ6MXJaR2dJV08wZQpwSURiMktEV25pM3BNaEZNWDVjcUhHVVI5R3dUU0phclFhMFRVcnpI dnhJeGdPem5xaWorTjM5dUZEVSs1VkxWCjVycjFDUnp5T0NDSFJBUDRocjhIMFQ2TGtUUmVzaDJn YmpFNEVPRXZadmxmRmZZd2pHd3hOWm1naHpyTVZjdkcKdkpZUnRHV1UxUE00R2UzV1VJRklnRUV0 TFRsa3JGb3dCeGNsc2lCRzVmaEJNR2p6VUlDYVdzOG90K1hwbmk5OApzNkVxRTFWTm5GUGpKNHZ2 ajZDaUhsWC80MGIzYlRCMDRJb3hNRUZBZjMvQmNZUzQxYzFFUTNxMGVLZ3I4NitPCmhJM0luSDcv VldLL0E5QS9ROTlJbjU1bkxRci9aQ1ZWQ3RGT0wwUUpBLzJRT3ROZ2FjWkt1UFp5Zzg0T25ISE4K WkhHUEEyWWtRaEwweEwzb0FnS3FrYTJxdUZ1QTBGQTE4VlFqa3ZVcFRXbHRFdS9CTUxwMFMvcG5z L0dEZW5CaQpZa0lSckp1SytiREcwS0Q5N1hOR1BlUlhvOTAzQnhJY3VCRVNzbHArS2JDNi83MFdk dmJJY1U0cS9tSnZ1SGZWCnhXMnVqRFl5VmYrUFJPc1RwZjNTRnRXTWJmekFDbE1yaDZYMnd4NjlW aWdOZlFRd2wyTkZYcFAzNkl6WEh0ZnIKN2loeFZGd3hoQk52a1JzenFrWWxCZzJqaWx1WEljSGJU Q25yclVuNmdrUDJvMnFuMXBtWitXYVJaVTdzVVcwNgpFWTI5S0Z0R2p2V3JaQ1FmcHAyVHJpQU8y MGJwc3c4bTlsSGU3VFdZYUY5MTk0QTdWSHNpdnV1ZnNYZUtqZmx6ClZONXR1ZzN2OUhRQ1l2aGF4 aDlPCj1YdDloCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============5909051313222103364==--