From: Minchan Kim <minchan@kernel.org>
To: David Horner <ds2horner@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: [RFC 2/3] zsmalloc/zram: add zs_get_max_size_bytes and use it in zram
Date: Tue, 12 Aug 2014 07:18:30 +0000 [thread overview]
Message-ID: <20140812071830.GA23902@gmail.com> (raw)
In-Reply-To: <loom.20140808T045014-594@post.gmane.org>
Hello,
Sorry for the late response. I was on vacation and then was busy.
On Fri, Aug 08, 2014 at 02:56:24AM +0000, David Horner wrote:
>
> [2/3]
>
>
> But why isn't mem_used_max writable? (save tearing down and rebuilding
> device to reset max)
I don't know what you mean but I will make it writable so user can
reset it to zero when they want.
>
> static DEVICE_ATTR(mem_used_max, S_IRUGO, mem_used_max_show, NULL);
>
> static DEVICE_ATTR(mem_used_max, S_IRUGO | S_IWUSR, mem_used_max_show, NULL);
>
> with a check in the store() that the new value is positive and less
> than current max?
>
>
> I'm also a little puzzled why there is a new API zs_get_max_size_bytes if
> the data is accessible through sysfs?
> Especially if max limit will be (as you propose for [3/3]) through accessed
> through zsmalloc and hence zram needn't access.
I don't know why you meant.
Anyway, I will resend revised version and Cc you.
Please, comment on that. :)
>
>
>
> [3/3]
> I concur that the zram limit is best implemented in zsmalloc.
> I am looking forward to that revised code.
Thanks!
>
>
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-08-12 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 2:56 [RFC 2/3] zsmalloc/zram: add zs_get_max_size_bytes and use it in zram David Horner
2014-08-12 7:18 ` Minchan Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-08 2:47 David Horner
2014-08-05 8:02 [RFC 0/3] zram memory control enhance Minchan Kim
2014-08-05 8:02 ` [RFC 2/3] zsmalloc/zram: add zs_get_max_size_bytes and use it in zram Minchan Kim
2014-08-05 8:02 ` Minchan Kim
2014-08-13 15:25 ` Seth Jennings
2014-08-13 15:25 ` Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812071830.GA23902@gmail.com \
--to=minchan@kernel.org \
--cc=ds2horner@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.