All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com>,
	lgirdwood@gmail.com, tiwai@suse.de, alsa-devel@alsa-project.org,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v3] ASOC: dapm: add code to configure dai link parameters
Date: Tue, 12 Aug 2014 20:40:14 +0530	[thread overview]
Message-ID: <20140812151014.GF13288@intel.com> (raw)
In-Reply-To: <20140811121912.GY17528@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

On Mon, Aug 11, 2014 at 01:19:12PM +0100, Mark Brown wrote:
> On Mon, Aug 11, 2014 at 11:54:29AM +0530, Vinod Koul wrote:
> > On Thu, Aug 07, 2014 at 06:13:24PM +0100, Mark Brown wrote:
> > > On Thu, Aug 07, 2014 at 07:46:05PM +0530, Vinod Koul wrote:
> 
> > > > I was thinking about this as well a while back, wont it make sense to let
> > > > machine driver expose meaningful controls for this. Just like we have fixup
> > > > for back-ends, we can add fixups for codec-codec links and let machine tell
> > > > you the parameters to configure.
> 
> > > This is supposed to be pretty much the same thing (not looked at the
> > > patch yet) - the machine driver passes in a list of possible settings
> > > and then a control gets generated allowing the user to pick one.
> 
> > Yes but this is bit different from the current way of using fixups for BEs.
> > So it would be bit incosistent. For pcms it would be only fixups and for
> > loops it would be machine controls
> 
> That doesn't mean it's the best way to go in the end though - long term
> I expect to see us move away from that to something more data driven and
> DAPM integrated.  Requiring drivers to open code things rather than
> factoring out the code doesn't seem like the right way forwards.
Okay if that is the direction then this sound good to me.

Only one last nitpick on how do we set different format value apart from
sample rate, bits etc here. We have devices talking on same port and each one is
different format(one use i2s, one uses tdm ...), so how do we handle that part?

Thanks
-- 
~Vinod

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-08-12 15:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 16:16 [PATCH v3] ASOC: dapm: add code to configure dai link parameters Nikesh Oswal
2014-08-06 16:16 ` Nikesh Oswal
2014-08-07 14:16 ` [alsa-devel] " Vinod Koul
2014-08-07 14:16   ` Vinod Koul
2014-08-07 17:13   ` [alsa-devel] " Mark Brown
2014-08-11  6:24     ` Vinod Koul
2014-08-11 12:19       ` Mark Brown
2014-08-11 12:19         ` Mark Brown
2014-08-12 15:10         ` Vinod Koul [this message]
2014-08-12 22:03           ` [alsa-devel] " Mark Brown
2014-08-18 18:53 ` Mark Brown
2014-08-18 18:53   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812151014.GF13288@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikesh@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.