From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: naota@elisp.net, linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf report: Set proper sort__mode for the branch option
Date: Wed, 13 Aug 2014 17:14:34 -0300 [thread overview]
Message-ID: <20140813201434.GI2718@kernel.org> (raw)
In-Reply-To: <877g2ddjsx.fsf@sejong.aot.lge.com>
Em Wed, Aug 13, 2014 at 02:45:34PM +0900, Namhyung Kim escreveu:
> Hi Naohiro,
>
> (CC'ing Stephane)
>
> > When you specify "--branch-stack"("-b" for short) or
> > "--no-branch-stack", "branch_mode" variable is set to 1 or 0
> > respectively. However, the code is just checking if the variable is -1
> > or not, ignoring "branch_mode == 1" case. Thus "perf report -b" dose not
> > show its result with the branch sorted mode. This patch fix the problem.
> >
> > Signed-off-by: Naohiro Aota <naota@elisp.net>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks for fixing this!
> Namhyung
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2014-08-13 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 15:04 [PATCH] perf report: Set proper sort__mode for the branch option naota
2014-08-13 5:45 ` Namhyung Kim
2014-08-13 20:14 ` Arnaldo Carvalho de Melo [this message]
2014-08-14 8:49 ` [tip:perf/core] " tip-bot for naota@elisp.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813201434.GI2718@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naota@elisp.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.