From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbaHONLl (ORCPT ); Fri, 15 Aug 2014 09:11:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51278 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbaHONLk (ORCPT ); Fri, 15 Aug 2014 09:11:40 -0400 Date: Fri, 15 Aug 2014 06:11:37 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Linux Kernel Mailing List , Andrew Morton , Dave Kleikamp , Zach Brown , Benjamin LaHaise , Christoph Hellwig , Kent Overstreet , "open list:AIO" , Linux FS Devel , Dave Chinner Subject: Re: [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Message-ID: <20140815131137.GA31079@infradead.org> References: <1408031441-31156-1-git-send-email-ming.lei@canonical.com> <53ECE998.8070407@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 15, 2014 at 08:59:56PM +0800, Ming Lei wrote: > Your concern is right, previous I thought that mq conversion wouldn't improve > throughput, but I did ignore workqueue's concurrency management, it > turns out blk-mq conversion can improvment throughput close to 10 times in > my test(loop over virtio-blk which is backed by one image on SSD). It is like > POSIX style AIO after mq conversion thanks to workqueue, and I need to > update the performance data in V2. > > Actually kernel AIO needn't such high concurrency. Can you juse send a loop blk-mq conversion for now? I think that's a bit less controversial than the new kernel aio APIs, and keeping the two separate is a good idea in general. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Date: Fri, 15 Aug 2014 06:11:37 -0700 Message-ID: <20140815131137.GA31079@infradead.org> References: <1408031441-31156-1-git-send-email-ming.lei@canonical.com> <53ECE998.8070407@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , Linux Kernel Mailing List , Andrew Morton , Dave Kleikamp , Zach Brown , Benjamin LaHaise , Christoph Hellwig , Kent Overstreet , "open list:AIO" , Linux FS Devel , Dave Chinner To: Ming Lei Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Aug 15, 2014 at 08:59:56PM +0800, Ming Lei wrote: > Your concern is right, previous I thought that mq conversion wouldn't improve > throughput, but I did ignore workqueue's concurrency management, it > turns out blk-mq conversion can improvment throughput close to 10 times in > my test(loop over virtio-blk which is backed by one image on SSD). It is like > POSIX style AIO after mq conversion thanks to workqueue, and I need to > update the performance data in V2. > > Actually kernel AIO needn't such high concurrency. Can you juse send a loop blk-mq conversion for now? I think that's a bit less controversial than the new kernel aio APIs, and keeping the two separate is a good idea in general. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org