From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Mon, 18 Aug 2014 11:55:42 +0900 Subject: [U-Boot] [PATCH v2 02/15] zynq: kconfig: move board select menu and commonsettings In-Reply-To: References: <20140806184813.96D4.AA925319@jp.panasonic.com> Message-ID: <20140818115541.674B.AA925319@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michal, On Wed, 6 Aug 2014 13:27:27 +0200 Michal Simek wrote: > > > > In this case, savedefconfig was done based on > > configs/sandbox_defconfig which is empty for now, > > but which will have more options in the future. > > No problem with that. > The question and my concern is that every .config > will contain this line and this is just one usage > which is questionable. IMHO if there is no .config > savedefconfig should failed to let user to know > that something is wrong. But that's just my opinion. Finally, I have posted a patch. http://patchwork.ozlabs.org/patch/380400/ > > > > Whereas, this case, savedefconfig failed, > > that is why the file is empty. > > It doesn't look at it is failing - just don't use that default one. You are right. It seems to exit successfully with doing nothing. Best Regards Masahiro Yamada