All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	viro@zeniv.linux.org.uk, jonas.jensen@gmail.com
Subject: Re: [PATCH] fs: Initialize mountpoint list head in new_mountpoint()
Date: Tue, 19 Aug 2014 09:01:45 +0200	[thread overview]
Message-ID: <20140819070143.GB12859@ulmo> (raw)
In-Reply-To: <1408416234-7923-1-git-send-email-mopsfelder@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Mon, Aug 18, 2014 at 11:43:54PM -0300, Murilo Opsfelder Araujo wrote:
> The commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736 makes next-20140818
> to panic because mountpoint list head was not initialized.  Initializing
> it with NULL fixes the problem.
> 
> commit 89f7ca1af15bdfe7a6aed343032a84af2a69f736
> Author: Eric W. Biederman <ebiederman@twitter.com>
> Date:   Sun Sep 22 19:37:01 2013 -0700
> 
>     vfs: Keep a list of mounts on a mount point
> 
>     To spot any possible problems call BUG if a mountpoint
>         is put when it's list of mounts is not empty.
> 
>     AV: use hlist instead of list_head
> 
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
> ---
>  fs/namespace.c | 1 +
>  1 file changed, 1 insertion(+)

It's considered good etiquette and polite to credit the original author
of a patch. This should be:

Originally-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-08-19  7:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 11:09 fs: panic in mnt_set_mountpoint Jonas Jensen
2014-08-18 12:08 ` Ming Lei
2014-08-18 15:33 ` Thierry Reding
2014-08-18 19:33   ` Kevin Hilman
2014-08-19  2:43   ` [PATCH] fs: Initialize mountpoint list head in new_mountpoint() Murilo Opsfelder Araujo
2014-08-19  7:01     ` Thierry Reding [this message]
2014-08-19 13:49       ` Murilo Opsfelder Araújo
2014-08-20 12:35   ` fs: panic in mnt_set_mountpoint Jonas Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140819070143.GB12859@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=jonas.jensen@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mopsfelder@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.