From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 19 Aug 2014 10:28:11 +0200 Subject: [U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy In-Reply-To: <1408372115-4570-12-git-send-email-kishon@ti.com> References: <1408372115-4570-1-git-send-email-kishon@ti.com> <1408372115-4570-12-git-send-email-kishon@ti.com> Message-ID: <20140819102811.1926b36b@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Kishon, > Implemented __weak functions for board_usb_cleanup, > board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts > to get of compiler errors in platforms that haven't implemented > these functions. > > Signed-off-by: Kishon Vijay Abraham I > --- > common/usb.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/common/usb.c b/common/usb.c > index 60daa10..892bf7c 100644 > --- a/common/usb.c > +++ b/common/usb.c > @@ -1072,4 +1072,22 @@ int board_usb_init(int index, enum > usb_init_type init) { > return 0; > } > + > +__weak > +int board_usb_cleanup(int index, enum usb_init_type init) > +{ > + return 0; > +} This needed before [PATCH 7/13]. Without it your code will cause u-boot repository to not be bisectable. > + > +__weak > +int board_usb_gadget_handle_interrupts(int index) > +{ > + return 0; > +} > + > +__weak > +int usb_gadget_handle_interrupts(void) > +{ > + return 0; > +} > /* EOF */ -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group