From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 08/14] drm/i915: Flatten
 intel_edp_panel_vdd_on()
Date: Tue, 19 Aug 2014 13:49:43 +0300
Message-ID: <20140819104943.GA4193@intel.com>
References: <1408389369-22898-1-git-send-email-ville.syrjala@linux.intel.com>
 <1408389369-22898-9-git-send-email-ville.syrjala@linux.intel.com>
 <87zjf1gcmm.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 36E5F6E591
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Aug 2014 03:50:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87zjf1gcmm.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 19, 2014 at 10:30:25AM +0300, Jani Nikula wrote:
> On Mon, 18 Aug 2014, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > Less pointless indentation is always nice. There will be a bit more
> > code in this function once the power sequencer locking is fixed.
> =

> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> =

> This could be earlier in the series, right?

Yeah doens't really matter. Or could even be squashed with the locking
patch.

> =

> >
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/int=
el_dp.c
> > index 0fb510c..7ae9a9a 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -1221,11 +1221,14 @@ static bool edp_panel_vdd_on(struct intel_dp *i=
ntel_dp)
> >  =

> >  void intel_edp_panel_vdd_on(struct intel_dp *intel_dp)
> >  {
> > -	if (is_edp(intel_dp)) {
> > -		bool vdd =3D edp_panel_vdd_on(intel_dp);
> > +	bool vdd;
> >  =

> > -		WARN(!vdd, "eDP VDD already requested on\n");
> > -	}
> > +	if (!is_edp(intel_dp))
> > +		return;
> > +
> > +	vdd =3D edp_panel_vdd_on(intel_dp);
> > +
> > +	WARN(!vdd, "eDP VDD already requested on\n");
> >  }
> >  =

> >  static void edp_panel_vdd_off_sync(struct intel_dp *intel_dp)
> > -- =

> > 1.8.5.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> -- =

> Jani Nikula, Intel Open Source Technology Center

-- =

Ville Syrj=E4l=E4
Intel OTC