All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core from linux kernel
Date: Tue, 19 Aug 2014 17:38:42 +0200	[thread overview]
Message-ID: <20140819173842.1635c769@amdc2363> (raw)
In-Reply-To: <20140819152808.GJ16085@saruman.home>

Hi Felipe, Kishon

> On Tue, Aug 19, 2014 at 08:48:36PM +0530, Kishon Vijay Abraham I
> wrote:
> > Hi Lukasz,
> > 
> > On Tuesday 19 August 2014 02:22 PM, Lukasz Majewski wrote:
> > > Hi Kishon,
> > > 
> > >> In order to support multiple USB device controllers in uboot,
> > >> udc-core is needed.
> > > 
> > > Is it? In u-boot at best only one UDC is operational at a time.
> > 
> > I didn't mean operational at the same time. dra7xx has 4 USB
> > controllers and we should allow the user to use any USB port for
> > DFU.
> 
> but from u-boot's perspective, that can (should?) be a build-time
> choice. That user, certainly, won't need more than one port active for
> booting, right ?

This is my point. We are working with the bootloader. Some things here
are set at board configuration and aren't changed afterwards (like
only UDC 0 output is wired out).

The dfu/ums commands give you the ability to specify controller if
you need such option.

> 
> > >> udc-core also helps to cleanly link the USB
> > >> peripheral driver with the gadget driver. Hence Ported minimal
> > >> udc-core from linux kernel.
> > > 
> > > I'd appreciate the exact SHA for this udc-core.c code. And the SHA
> > > should be from some already released mainline code (like final
> > > 3.16), not any private branch nor linux-next.
> > 
> > We can't have the exact udc-core.c from linux kernel as it deals
> > with kernel driver model stuff and vfs which is not needed for
> > kernel. Trying to have the exact same code from kernel complicates
> > it.
> 
> what he means is to point to the SHA1 when you originally forked the
> code from kernel. Sure udc-core can't be the same, but you based off
> of a known commit ID frmo the kernel.
> 

+1

The best way is to grab original source from mailine kernel, and then
provide patch which adjust it. In this way we have clean trace from
where the code comes.


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2014-08-19 15:38 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 14:28 [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 01/13] include: linux: preparation for porting dwc3 from linux kernel Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core " Kishon Vijay Abraham I
2014-08-18 14:36   ` Felipe Balbi
2014-08-19 14:58     ` Kishon Vijay Abraham I
2014-08-19  8:52   ` Lukasz Majewski
2014-08-19 15:11     ` Felipe Balbi
2014-08-19 15:18     ` Kishon Vijay Abraham I
2014-08-19 15:28       ` Felipe Balbi
2014-08-19 15:38         ` Lukasz Majewski [this message]
2014-08-19 16:06         ` Kishon Vijay Abraham I
2014-08-20  7:02           ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 03/13] ARM: DRA7: Enable clocks for USB OTGSS and USB PHY Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 04/13] usb: dwc3: Add dwc3 driver Kishon Vijay Abraham I
2014-08-18 14:37   ` Felipe Balbi
2014-08-19 15:19     ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 05/13] usb: dwc3-omap: Add dwc3 glue driver for OMAP Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 06/13] usb: dwc3: TI PHY: PHY driver for dwc3 in TI platforms Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly set the max packet size in descriptor Kishon Vijay Abraham I
2014-08-18 14:38   ` Felipe Balbi
2014-08-18 14:49     ` Lukasz Majewski
2014-08-18 14:56     ` Lukasz Majewski
2014-08-19 15:38       ` Kishon Vijay Abraham I
2014-08-19 15:44         ` Felipe Balbi
2014-08-20  7:34           ` Lukasz Majewski
2014-08-20 16:11             ` Felipe Balbi
2014-08-21  8:00               ` Lukasz Majewski
2014-08-21 13:50                 ` Felipe Balbi
2014-08-20  7:23         ` Lukasz Majewski
2014-08-19 15:34     ` Kishon Vijay Abraham I
2014-08-19 15:39       ` Felipe Balbi
2014-08-19 15:42         ` Kishon Vijay Abraham I
2014-08-19 15:48           ` Felipe Balbi
2014-08-19 15:53             ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 08/13] common: cmd_dfu: invoke board_usb_cleanup() for cleaning up Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 09/13] common: cmd_dfu: add an API that takes controller index for handling interrupts Kishon Vijay Abraham I
2014-08-19  8:53   ` Lukasz Majewski
2014-08-19 16:09     ` Kishon Vijay Abraham I
2014-08-20  7:37       ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 10/13] board: ti: DRA7: added USB initializtion code Kishon Vijay Abraham I
2014-08-18 14:40   ` Felipe Balbi
2014-08-19 16:13     ` Kishon Vijay Abraham I
2014-08-19 16:26       ` Felipe Balbi
2014-08-22 10:47         ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy Kishon Vijay Abraham I
2014-08-19  8:28   ` Lukasz Majewski
2014-08-19 16:14     ` Kishon Vijay Abraham I
2014-08-21 17:32       ` Tom Rini
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 12/13] include: configs: Enable DWC3 and DFU in DRA7xx Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 13/13] dwc3: core: Change the bounce buffer size to 4096 Kishon Vijay Abraham I
2014-08-18 14:41   ` Felipe Balbi
2014-08-19 16:15     ` Kishon Vijay Abraham I
2014-08-19 16:27       ` Felipe Balbi
2014-08-22 11:02         ` Kishon Vijay Abraham I
2014-08-22 13:54           ` Felipe Balbi
2014-08-18 15:29 ` [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Tom Rini
2014-08-19  8:56 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140819173842.1635c769@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.