All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@fedoraproject.org>
To: lvm-devel@redhat.com
Subject: master - tests: proper /dev access
Date: Wed, 20 Aug 2014 12:38:20 +0000 (UTC)	[thread overview]
Message-ID: <20140820123820.071B560080@fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=473a4a65485d881edfb2220a2e8f3d4fbf228818
Commit:        473a4a65485d881edfb2220a2e8f3d4fbf228818
Parent:        8d00499167f010b82ea6ddebcc6b22ec170002f9
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Wed Aug 20 14:35:57 2014 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Aug 20 14:37:41 2014 +0200

tests: proper /dev access

Commit 5ebff6cc9f631b7409d99b72fa0b39ccec30bf1f seemed to introduce
new 'for' loop but the mode is not yet used.
But the access to /dev dir needs to go through $DM_DEV_DIR
and whole path needs to be in "".
---
 test/shell/pvmove-restart.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/test/shell/pvmove-restart.sh b/test/shell/pvmove-restart.sh
index f480aaa..dde7308 100644
--- a/test/shell/pvmove-restart.sh
+++ b/test/shell/pvmove-restart.sh
@@ -39,8 +39,9 @@ kill -9 $PVMOVE
 wait
 
 # Simulate reboot - forcibly remove related devices
+dmsetup table
 dmsetup remove $vg-$lv1
-dmsetup remove /dev/mapper/$vg-pvmove0*
+dmsetup remove "$DM_DEV_DIR/mapper/$vg-pvmove0*"
 
 # Check we really have pvmove volume
 check lv_attr_bit type $vg/pvmove0 "p"



                 reply	other threads:[~2014-08-20 12:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140820123820.071B560080@fedorahosted.org \
    --to=zkabelac@fedoraproject.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.