From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbaHTPEw (ORCPT ); Wed, 20 Aug 2014 11:04:52 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:17652 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbaHTPEu (ORCPT ); Wed, 20 Aug 2014 11:04:50 -0400 X-AuditID: cbfec7f4-b7f156d0000063c7-07-53f4b91023a9 Subject: [PATCH 3/7] mm/balloon_compaction: isolate balloon pages without lru_lock From: Konstantin Khlebnikov To: linux-mm@kvack.org, Andrew Morton , Rafael Aquini Cc: Sasha Levin , Andrey Ryabinin , linux-kernel@vger.kernel.org Date: Wed, 20 Aug 2014 19:04:46 +0400 Message-id: <20140820150446.4194.5716.stgit@buzz> In-reply-to: <20140820150435.4194.28003.stgit@buzz> References: <20140820150435.4194.28003.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t/xq7oCO78EG6zqV7GYs34Nm8WMh79Y LH7s7GW1uLxrDpvFvTX/WS2Ob93CbLH4yG1mB3aPnbPusnts+jSJ3ePEjN8sHh+f3mLxeL/v KptH35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZRw52sdecJmt4seM0ywNjDtYuxg5OCQETCQu bo3sYuQEMsUkLtxbz9bFyMUhJLCUUaLn3QdmCKeRSeLuy/lsIFXCAiES9zf8YwGx2QTMJLbt u80IYosIpEl8fbYFrIZZoEjixc1ZYDaLgKrEoof7mUBsXgFDiVXP7oPZnALGEmuOvwTrFRIw krjW85sZxBYVkJNYebmFFaJeUOLH5HssIIcyC6hLTJmSCzFeXmLzmrfMExgFZiGpmoVQNQtJ 1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYIUH/ZQfj4mNWhxgFOBiVeHhvLPoSLMSa WFZcmXuIUYKDWUmE98QGoBBvSmJlVWpRfnxRaU5q8SFGJg5OqQZGucMxIRxSjP4vCzqtn7K8 T+0s1RY+c910r3y0+oyiKz0PTN6pcn0u4vD9HDffoF+7NOXqJOFbdd75t5uXV35vVbMTVVdc e3Pe6iP/786PX/+SVyDy5Y68jBUhax1KPEPdCpdmSszw69jnWrbrz6NFJ2y2HpT/PutP9E/l dwpzypKsJgVP7TupxFKckWioxVxUnAgA2IWNQFgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LRU-lock isn't required for balloon page isolation. This check makes migration of some ballooned pages mostly impossible because isolate_migratepages_range() drops LRU lock periodically. Signed-off-by: Konstantin Khlebnikov Cc: stable # v3.8 --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 21bf292..0653f5f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -597,7 +597,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, */ if (!PageLRU(page)) { if (unlikely(balloon_page_movable(page))) { - if (locked && balloon_page_isolate(page)) { + if (balloon_page_isolate(page)) { /* Successfully isolated */ goto isolate_success; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id 4890C6B0038 for ; Wed, 20 Aug 2014 11:05:04 -0400 (EDT) Received: by mail-pa0-f46.google.com with SMTP id lj1so12203882pab.33 for ; Wed, 20 Aug 2014 08:05:01 -0700 (PDT) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by mx.google.com with ESMTPS id fk8si21120758pdb.143.2014.08.20.08.04.56 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Wed, 20 Aug 2014 08:04:57 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NAM006KJ20T2560@mailout2.w1.samsung.com> for linux-mm@kvack.org; Wed, 20 Aug 2014 16:07:41 +0100 (BST) Subject: [PATCH 3/7] mm/balloon_compaction: isolate balloon pages without lru_lock From: Konstantin Khlebnikov Date: Wed, 20 Aug 2014 19:04:46 +0400 Message-id: <20140820150446.4194.5716.stgit@buzz> In-reply-to: <20140820150435.4194.28003.stgit@buzz> References: <20140820150435.4194.28003.stgit@buzz> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org, Andrew Morton , Rafael Aquini Cc: Sasha Levin , Andrey Ryabinin , linux-kernel@vger.kernel.org LRU-lock isn't required for balloon page isolation. This check makes migration of some ballooned pages mostly impossible because isolate_migratepages_range() drops LRU lock periodically. Signed-off-by: Konstantin Khlebnikov Cc: stable # v3.8 --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 21bf292..0653f5f 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -597,7 +597,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, */ if (!PageLRU(page)) { if (unlikely(balloon_page_movable(page))) { - if (locked && balloon_page_isolate(page)) { + if (balloon_page_isolate(page)) { /* Successfully isolated */ goto isolate_success; } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org