From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XK7at-0006qp-Qg
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 11:14:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XK7an-00032z-LU
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 11:14:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39426)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XK7an-00032n-DQ
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 11:14:29 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KFER8p024500
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 20 Aug 2014 11:14:28 -0400
Date: Wed, 20 Aug 2014 17:14:24 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140820151424.GI6122@noname.redhat.com>
References: <1405707901-8253-1-git-send-email-mreitz@redhat.com>
	<1405707901-8253-3-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1405707901-8253-3-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/6] blkdebug: Implement
	bdrv_refresh_filename()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 18.07.2014 um 20:24 hat Max Reitz geschrieben:
> Because blkdebug cannot simply create a configuration file, simply
> refuse to reconstruct a plain filename and only generate an options
> QDict from the rules instead.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Instead of this rather complicated implementation, we could decide to
> just drop it and let this be handled by the default implementation. The
> default implementation however cannot generate full_open_options in case
> a configuration file was given; in that case, it would just return the
> filename containing the name of the configuration file. On the other
> hand, blkdebug is just a debug driver anyway, so it probably wouldn't
> hurt too much.

I think you really want to have the config file name used here for
options that were loaded from a config file, and the explicit JSON
notation only for options explicitly specified on the command line or in
blockdev-add.

We still only have 1024 characters for bs->filename... ;-)

Kevin