Re: [Powertop] [PATCH 09/14] do not use ncurses when --auto-tune is specified

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2333 bytes --]

On (08/20/14 23:56), Sami Kerola wrote:
> Hello Sergey and others,
> 
> I had a bit of spare time so I started to look what exactly is calling
> mvprintw() via ui_notify_user().  My initial reaction was that I must
> have made some error in search, because I could not find such call.  So I
> added abort() to the code...
> 
> index b482296..55c9603 100644
> --- a/src/lib.cpp
> +++ b/src/lib.cpp
> @@ -546,5 +546,6 @@ void ui_notify_user(const char *frmt, ...)
>         vsnprintf(notify, UI_NOTIFY_BUFF_SZ - 1, frmt, list);
>         va_end(list);
>         mvprintw(1, 0, notify);
> +       abort();
>         attroff(COLOR_PAIR(1));
>  }
> 
> ...and found the --auto-tune does not entering to that function.  When
> running in normal mode the call path is from main() -> one_measurement()
> -> do_sleep() -> cursor_enter() -> tuning_window::cursor_enter ->
> ui_notify_user() -> mvprintw().
> 

oh, yes. my bad, I didn't double check.
auto-tune calls all_tunables[i]->toggle() directly.

ok. then everything should be fine.

	-ss

> I also realized the --auto-tune is setting leave_powertop = 1, which
> means the patch 0009 can be simplified.  Here is better version of the
> change that avoids running unnecessary if().
> 
> --->8----
> From: Sami Kerola <kerolasa(a)iki.fi>
> Date: Wed, 20 Aug 2014 23:31:52 +0300
> Subject: [PATCH 09/14] do not use ncurses when --auto-tune is specified
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
> Signed-off-by: Sami Kerola <kerolasa(a)iki.fi>
> ---
>  src/main.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/main.cpp b/src/main.cpp
> index 3b67ef0..bd0fc88 100644
> --- a/src/main.cpp
> +++ b/src/main.cpp
> @@ -460,7 +460,8 @@ int main(int argc, char **argv)
>  		end_pci_access();
>  		exit(0);
>  	}
> -	init_display();
> +	if (!auto_tune)
> +		init_display();
>  	initialize_tuning();
>  	/* first one is short to not let the user wait too long */
>  	one_measurement(1, NULL);
> @@ -477,7 +478,8 @@ int main(int argc, char **argv)
>  		one_measurement(time_out, NULL);
>  		learn_parameters(15, 0);
>  	}
> -	endwin();
> +	if (!auto_tune)
> +		endwin();
>  	printf("%s\n", _("Leaving PowerTOP"));
>  
>  	end_process_data();
> -- 
> 2.1.0
>