From: Lee Jones <lee.jones@linaro.org>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kyungmin.park@samsung.com, b.zolnierkie@samsung.com,
Andrzej Hajda <a.hajda@samsung.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
SangYoung Son <hello.son@smasung.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH/RFC v5 2/3] leds: Add support for max77693 mfd flash cell
Date: Thu, 21 Aug 2014 17:00:54 +0100 [thread overview]
Message-ID: <20140821160054.GQ4266@lee--X1> (raw)
In-Reply-To: <1408542221-375-3-git-send-email-j.anaszewski@samsung.com>
On Wed, 20 Aug 2014, Jacek Anaszewski wrote:
> This patch adds led-flash support to Maxim max77693 chipset.
> A device can be exposed to user space through LED subsystem
> sysfs interface or through V4L2 subdevice when the support
> for V4L2 Flash sub-devices is enabled. Device supports up to
> two leds which can work in flash and torch mode. Leds can
> be triggered externally or by software.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: SangYoung Son <hello.son@smasung.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/leds/Kconfig | 9 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-max77693.c | 1048 ++++++++++++++++++++++++++++++++++
> drivers/mfd/max77693.c | 5 +-
> include/linux/mfd/max77693-private.h | 59 ++
> include/linux/mfd/max77693.h | 40 ++
Please break the MFD changes out into a separate patch, I can't (at
first glace) see any reason why the changed need to be bundled
together like this.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-21 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:43 [PATCH/RFC v5 0/3] LED / flash API integration - LED Flash Class drivers Jacek Anaszewski
2014-08-20 13:43 ` Jacek Anaszewski
2014-08-20 13:43 ` [PATCH/RFC v5 1/3] mfd: max77693: Fix register enum name Jacek Anaszewski
2014-08-21 16:02 ` Lee Jones
2014-08-20 13:43 ` [PATCH/RFC v5 2/3] leds: Add support for max77693 mfd flash cell Jacek Anaszewski
2014-08-21 16:00 ` Lee Jones [this message]
2014-08-20 13:43 ` [PATCH/RFC v5 3/3] leds: Add driver for AAT1290 current regulator Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821160054.GQ4266@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hello.son@smasung.com \
--cc=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.