From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKWIe-0004Rw-N7 for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:37:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKWIa-000844-8D for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:37:24 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:59359 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKWIZ-00083y-Sw for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:37:20 -0400 Date: Thu, 21 Aug 2014 19:36:33 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140821173633.GB26320@irqsave.net> References: <1408625048-21994-1-git-send-email-stefanha@redhat.com> <1408625048-21994-3-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1408625048-21994-3-git-send-email-stefanha@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add test case 101 for short file I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Markus Armbruster The Thursday 21 Aug 2014 =E0 13:44:08 (+0100), Stefan Hajnoczi wrote : > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/101 | 58 ++++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/101.out | 10 ++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 69 insertions(+) > create mode 100755 tests/qemu-iotests/101 > create mode 100644 tests/qemu-iotests/101.out >=20 > diff --git a/tests/qemu-iotests/101 b/tests/qemu-iotests/101 > new file mode 100755 > index 0000000..70fbf25 > --- /dev/null > +++ b/tests/qemu-iotests/101 > @@ -0,0 +1,58 @@ > +#!/bin/bash > +# > +# Test short file I/O > +# > +# Copyright (C) 2014 Red Hat, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see = . > +# > + > +# creator > +owner=3Dstefanha@redhat.com > + > +seq=3D`basename $0` > +echo "QA output created by $seq" > + > +here=3D`pwd` > +tmp=3D/tmp/$$ > +status=3D1 # failure is the default! > + > +_cleanup() > +{ > + _cleanup_test_img > +} > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +# get standard environment, filters and checks > +. ./common.rc > +. ./common.filter > + > +_supported_fmt raw > +_supported_proto file > +_supported_os Linux > + > + > +echo > +echo "=3D=3D creating short image file =3D=3D" > +dd if=3D/dev/zero of=3D"$TEST_IMG" bs=3D1 count=3D320 > + > +echo > +echo "=3D=3D reading bytes beyond EOF gives zeroes =3D=3D" We could pad the file with 0xFF to make sure the read really get only zer= oes. Reviewed-by: Beno=EEt Canet > +$QEMU_IO -c "read -P 0 0 512" "$TEST_IMG" | _filter_qemu_io > + > + > +# success, all done > +echo "*** done" > +rm -f $seq.full > +status=3D0 > diff --git a/tests/qemu-iotests/101.out b/tests/qemu-iotests/101.out > new file mode 100644 > index 0000000..9a996e8 > --- /dev/null > +++ b/tests/qemu-iotests/101.out > @@ -0,0 +1,10 @@ > +QA output created by 101 > + > +=3D=3D creating short image file =3D=3D > +320+0 records in > +320+0 records out > + > +=3D=3D reading bytes beyond EOF gives zeroes =3D=3D > +read 512/512 bytes at offset 0 > +512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +*** done > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 6e67f61..e25e992 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -100,3 +100,4 @@ > 091 rw auto quick > 092 rw auto quick > 095 rw auto quick > +101 rw auto quick > --=20 > 1.9.3 >=20 >=20