From: David Miller <davem@davemloft.net>
To: linux@rasmusvillemoes.dk
Cc: ariel.elior@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef
Date: Fri, 22 Aug 2014 11:30:19 -0700 (PDT) [thread overview]
Message-ID: <20140822.113019.1690922235326790002.davem@davemloft.net> (raw)
In-Reply-To: <87mwaxrnbg.fsf@rasmusvillemoes.dk>
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: Fri, 22 Aug 2014 09:33:07 +0200
> David Miller <davem@davemloft.net> writes:
>
>> From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> Date: Wed, 20 Aug 2014 15:14:49 +0200
>>
>>> Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for
>>> 64 bit longs, and u64 should be printed using %llx anyway.
>>>
>>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>>
>> It's not correct and will warn on some platforms where "u64" is just
>> a plain "unsigned long".
>>
>> Ie. all of those which use include/asm-generic/int-l64.h
>
> Of which there are none; that file no longer exists (as I said, nothing
> defines that macro). Please see 0c79a8e2 ("asm/types.h: Remove
> include/asm-generic/int-l64.h") and 2a7930bd
> ("Documentation/printk-formats.txt: No casts needed for u64/s64").
Ok that makes sense, applied, thank you.
prev parent reply other threads:[~2014-08-22 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:14 [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef Rasmus Villemoes
2014-08-22 4:37 ` David Miller
2014-08-22 7:33 ` Rasmus Villemoes
2014-08-22 18:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822.113019.1690922235326790002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariel.elior@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.