From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34155)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XKgSz-0004B5-ME
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:28:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XKgSo-0003QO-W6
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:28:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57672)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XKgSo-0003Pk-Oe
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:28:34 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7M4SXq5006431
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 22 Aug 2014 00:28:33 -0400
Date: Fri, 22 Aug 2014 12:28:48 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140822042848.GC3410@T430.redhat.com>
References: <1408622216-9578-1-git-send-email-famz@redhat.com>
	<1408622216-9578-9-git-send-email-famz@redhat.com>
	<20140821170153.GF22844@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140821170153.GF22844@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 8/9] block: Implement stub
 bdrv_em_co_aiocb_info.cancel_async
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Thu, 08/21 18:01, Stefan Hajnoczi wrote:
> On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote:
> > diff --git a/block.c b/block.c
> > index 1cc8926..1860e4b 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb)
> >      }
> >  }
> >  
> > +static void bdrv_aio_co_cancel_em_async(BlockDriverAIOCB *blockacb)
> > +{
> > +}
> 
> Please include a comment to explain why this function body is empty:
> 
> /* Do nothing, let caller wait for the request to complete */

OK.

Fam