All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chad Dupuis <chad.dupuis@qlogic.com>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
	Eddie Wai <eddie.wai@broadcom.com>,
	QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org,
	JBottomley@parallels.com, hch@lst.de
Subject: Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()
Date: Fri, 22 Aug 2014 14:11:06 +0200	[thread overview]
Message-ID: <20140822121106.GA14110@lst.de> (raw)
In-Reply-To: <alpine.OSX.2.00.1408220805170.360@administrators-macbook-pro.local>

On Fri, Aug 22, 2014 at 08:08:33AM -0400, Chad Dupuis wrote:
> Eddie, Maurizio,
>
> Since it looks like there can be a difference in the pdev would it make 
> sense instead to convert the unmap function to use the bare DMA API so 
> we're consistent in our use of hba->pcidev->dev?  Maybe something like 
> this:

This looks like a better plan to me.  Can you also document why you
are using plain dma_map/unmap_sg and a different dma device in the code?


  reply	other threads:[~2014-08-22 12:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:20 [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg() Maurizio Lombardi
2014-08-19 17:09 ` Christoph Hellwig
2014-08-20 13:22   ` Martin K. Petersen
2014-08-20 17:35 ` Eddie Wai
2014-08-22  9:10   ` Maurizio Lombardi
2014-08-22 12:08     ` Chad Dupuis
2014-08-22 12:11       ` Christoph Hellwig [this message]
2014-08-22 18:12       ` Maurizio Lombardi
2014-08-22 22:46         ` Eddie Wai
2014-08-25 19:15           ` Chad Dupuis
2014-08-26 18:35             ` Eddie Wai
2014-08-29 17:02               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140822121106.GA14110@lst.de \
    --to=hch@lst.de \
    --cc=JBottomley@parallels.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=chad.dupuis@qlogic.com \
    --cc=eddie.wai@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mlombard@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.