From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Fri, 22 Aug 2014 14:33:57 +0200 Subject: [U-Boot] [PATCH 19/23] ARM: tegra: Enable PCIe on Beaver In-Reply-To: <53F4EC6E.8030006@wwwdotorg.org> References: <1408346196-30419-1-git-send-email-thierry.reding@gmail.com> <1408346196-30419-20-git-send-email-thierry.reding@gmail.com> <53F4EC6E.8030006@wwwdotorg.org> Message-ID: <20140822123356.GB15686@ulmo> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Aug 20, 2014 at 12:43:58PM -0600, Stephen Warren wrote: > On 08/18/2014 01:16 AM, Thierry Reding wrote: > >From: Thierry Reding > > > >The Beaver has an ethernet NIC connected to the PCIe bus. Enable the > >PCIe controller and the network device driver so that the device can > >boot over the network. > > > >In addition the board has a mini-PCIe expansion slot. > > >diff --git a/arch/arm/dts/tegra30-beaver.dts b/arch/arm/dts/tegra30-beaver.dts > > >+ pcie-controller { > >+ status = "okay"; > >+ pex-clk-supply = <&sys_3v3_pexs_reg>; > >+ vdd-supply = <&ldo1_reg>; > >+ avdd-supply = <&ldo2_reg>; > > Just like TrimSlice, there are more regulator references in the kernel DT. > > The same comment applies to the next patch (i.e. the Cardhu DT patch) Done. I also added the unit address to the PCIe controller node name for consistency. > >+ regulators { > ... > >+ vdd_5v_in_reg: regulator at 0 { > ... > >+ sys_3v3_reg: regulator at 6 { > ... > >+ sys_3v3_pexs_reg: regulator at 7 { > > This only adds 3 of the regulators that are in the kernel DT. Can we just > add the whole regulators node so the two are consistent? Done. > >diff --git a/board/nvidia/cardhu/cardhu.c b/board/nvidia/cardhu/cardhu.c > > The commit description says Beaver... > > I guess this should be part of the next patch, and the two swapped? Done. Thanks, Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: