From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image
Date: Fri, 22 Aug 2014 17:38:59 -0400 [thread overview]
Message-ID: <20140822213859.GW19374@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ0dFPYYBQou-EYBe7Smv3HvoHZkRbi_F5KxQfW0egr8xw@mail.gmail.com>
On Fri, Aug 22, 2014 at 02:17:53PM -0600, Simon Glass wrote:
> Hi Bryan,
>
> On 15 August 2014 17:51, Bryan Wu <cooloney@gmail.com> wrote:
> >
> > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced
> > a bug for booting FIT image. It's because calling fit_parse_config()
> > twice will give us wrong value in img_addr.
> >
> > Add a new function genimg_get_kernel_addr_fit() whichl will always
> > return fit_uname_config and fit_uname_kernel for CONFIG_FIT.
> > genimg_get_kernel_addr() will ignore those to parameters.
> >
> > Reported-by: York Sun <yorksun@freescale.com>
> > Signed-off-by: Bryan Wu <pengw@nvidia.com>
>
> I think the function comment should be in the header file, but it's
> not important for now.
>
> The image.h file has a whitespace problem - tabs instead of spaces. If
> you run patman you will see it.
>
> Unfortunately the tests still fail due to two other issues. I'll send
> a few patches.
... but we're believing things are all fixed now, right?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/ed1f455a/attachment.pgp>
next prev parent reply other threads:[~2014-08-22 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 23:51 [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image Bryan Wu
2014-08-15 23:51 ` [U-Boot] [PATCH 2/2] bootm: make sure pass NULL when argc < 1 Bryan Wu
2014-08-22 20:37 ` Simon Glass
2014-08-23 12:43 ` [U-Boot] [U-Boot,2/2] " Tom Rini
2014-08-20 17:24 ` [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image Bryan Wu
2014-08-20 23:32 ` Simon Glass
2014-08-22 20:17 ` Simon Glass
2014-08-22 21:38 ` Tom Rini [this message]
2014-08-22 21:53 ` Tom Rini
2014-08-22 23:00 ` Simon Glass
2014-08-23 12:42 ` [U-Boot] [U-Boot, v3, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822213859.GW19374@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.