From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 00/10] locks/nfsd: internal lease API overhaul Date: Sun, 24 Aug 2014 09:10:46 -0700 Message-ID: <20140824161046.GI15908@infradead.org> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1408804878-1331-1-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: One more wishlist item in addition to the one mentioned in the patches: - add a return value to lm_break so that the lock manager can tell the core code "you can delete this lease right now". That gets rid of the games with the timeout which require all kinds of race avoidance code in the users. And a big one that doesn't seem easily addressable, but I'll drop it in anyway: - calling ->lm_break without i_lock would make everyones life a heck lot easier.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:58717 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbaHXQKr (ORCPT ); Sun, 24 Aug 2014 12:10:47 -0400 Date: Sun, 24 Aug 2014 09:10:46 -0700 From: Christoph Hellwig To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org, hch@infradead.org, cluster-devel@redhat.com, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 00/10] locks/nfsd: internal lease API overhaul Message-ID: <20140824161046.GI15908@infradead.org> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: One more wishlist item in addition to the one mentioned in the patches: - add a return value to lm_break so that the lock manager can tell the core code "you can delete this lease right now". That gets rid of the games with the timeout which require all kinds of race avoidance code in the users. And a big one that doesn't seem easily addressable, but I'll drop it in anyway: - calling ->lm_break without i_lock would make everyones life a heck lot easier.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sun, 24 Aug 2014 09:10:46 -0700 Subject: [Cluster-devel] [PATCH 00/10] locks/nfsd: internal lease API overhaul In-Reply-To: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> Message-ID: <20140824161046.GI15908@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit One more wishlist item in addition to the one mentioned in the patches: - add a return value to lm_break so that the lock manager can tell the core code "you can delete this lease right now". That gets rid of the games with the timeout which require all kinds of race avoidance code in the users. And a big one that doesn't seem easily addressable, but I'll drop it in anyway: - calling ->lm_break without i_lock would make everyones life a heck lot easier..