Re: [meta-oracle-java][PATCH] update jdk and jre to version 67

From: Martin Jansa <martin.jansa@gmail.com>
To: Vladimir Redzhepov <Vladimir_Redzhepov@epam.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [meta-oracle-java][PATCH] update jdk and jre to version 67
Date: Mon, 25 Aug 2014 15:30:04 +0200	[thread overview]
Message-ID: <20140825133004.GS20524@jama> (raw)
In-Reply-To: <85891bd4ce86459c9eec96447388fa5c@EPBYMINSA0001.epam.com>

[-- Attachment #1: Type: text/plain, Size: 7543 bytes --]

On Mon, Aug 25, 2014 at 01:00:08PM +0000, Vladimir Redzhepov wrote:
> 
> 
> -----Original Message-----
> From: Martin Jansa [mailto:martin.jansa@gmail.com] 
> Sent: Thursday, August 21, 2014 8:23 PM
> To: Vladimir Redzhepov
> Cc: yocto@yoctoproject.org
> Subject: Re: [yocto] [meta-oracle-java][PATCH] update jdk and jre to version 67
> 
> On Thu, Aug 21, 2014 at 05:01:47PM +0000, Vladimir Redzhepov wrote:
> > From f0305398a51435f407e41a8f0eaf83f8bdd13cca Mon Sep 17 00:00:00 2001
> > From: Vladimir Redzhepov <vladimir_redzhepov@epam.com>
> > Date: Thu, 21 Aug 2014 19:43:29 +0300
> > Subject: [PATCH] update jdk and jre to version 67
> > 
> > Signed-off-by: Vladimir Redzhepov <vladimir_redzhepov@epam.com>
> > ---
> > recipes-devtools/oracle-java/oracle-jse-jdk-i586_1.7.0.bb   | 10 +++++-----
> > recipes-devtools/oracle-java/oracle-jse-jdk-x86-64_1.7.0.bb | 10 +++++-----
> > recipes-devtools/oracle-java/oracle-jse-jre-i586_1.7.0.bb   | 10 +++++-----
> > recipes-devtools/oracle-java/oracle-jse-jre-x86-64_1.7.0.bb | 10 +++++-----
> > recipes-devtools/oracle-java/oracle-jse.inc                 |  4 ++--
> > 5 files changed, 22 insertions(+), 22 deletions(-)
> > 
> > diff --git a/recipes-devtools/oracle-java/oracle-jse-jdk-i586_1.7.0.bb b/recipes-devtools/oracle-java/oracle-jse-jdk-i586_1.7.0.bb
> > index 978fbd5..07fa39b 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse-jdk-i586_1.7.0.bb
> > +++ b/recipes-devtools/oracle-java/oracle-jse-jdk-i586_1.7.0.bb
> > @@ -1,9 +1,9 @@
> > -PR = "r0"
> > -PV_UPDATE = "25"
> > +PR = "r1"
> > +PV_UPDATE = "67"
> 
> Does it need PR update?
> 
> I thought that PR should be updated each time we modify recipe. That's why I've updated it.

We have automated PR service for that
https://wiki.yoctoproject.org/wiki/PR_Service

so please drop PR variable instead.

> >  require oracle-jse-jdk.inc
> > -SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u25-b15/jdk-7u25-linux-i586.tar.gz"
> > +SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u67-b01/jdk-7u67-linux-i586.tar.gz"
> 
> It would be better to use PV_UPDATE variable here and maybe introduce
> another one for build number?
> 
> Do you mean using PV_UPDATE in SRC_URI like this
> SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u${ PV_UPDATE }-b01/jdk-7u${ PV_UPDATE }-linux-i586.tar.gz" ?
> 
> Of course we can use additional variable for build number, for example BUILD_NUM = "b01"
> SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u${ PV_UPDATE }-${BUILD_NUM}/jdk-7u${ PV_UPDATE }-linux-i586.tar.gz"
> 

Yes, that's what I meant (without the spaces around PV_UPDATE), that way
it's easier to see what was changed in recipe when reviewing updates like this.

> > -SRC_URI[md5sum] = "23176d0ebf9dedd21e3150b4bb0ee776"
> > -SRC_URI[sha256sum] = "dd89b20afa939992bb7fdc44837fa64f0a98d7ee1e5706fe8a2d9e2247ba6de7"
> > +SRC_URI[md5sum] = "715b0e8ba2a06bded75f6a92427e2701"
> > +SRC_URI[sha256sum] = "b6231064ad2c9fbbcb099dba17b1dcf12033e922b9c24e4348b9a01e9ebaa85c"
> > diff --git a/recipes-devtools/oracle-java/oracle-jse-jdk-x86-64_1.7.0.bb b/recipes-devtools/oracle-java/oracle-jse-jdk-x86-64_1.7.0.bb
> > index 7979401..8bad119 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse-jdk-x86-64_1.7.0.bb
> > +++ b/recipes-devtools/oracle-java/oracle-jse-jdk-x86-64_1.7.0.bb
> > @@ -1,9 +1,9 @@
> > -PR = "r0"
> > -PV_UPDATE = "25"
> > +PR = "r1"
> > +PV_UPDATE = "67"
> >  require oracle-jse-jdk.inc
> > -SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u25-b15/jdk-7u25-linux-x64.tar.gz"
> > +SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u67-b01/jdk-7u67-linux-x64.tar.gz"
> > -SRC_URI[md5sum] = "83ba05e260813f7a9140b76e3d37ea33"
> > -SRC_URI[sha256sum] = "f80dff0e19ca8d038cf7fe3aaa89538496b80950f4d10ff5f457988ae159b2a6"
> > +SRC_URI[md5sum] = "81e3e2df33e13781e5fac5756ed90e67"
> > +SRC_URI[sha256sum] = "54dd1e13edf18c64941a55da9c91210b53dc5cf48f1a8f4538c863049e346335"
> > diff --git a/recipes-devtools/oracle-java/oracle-jse-jre-i586_1.7.0.bb b/recipes-devtools/oracle-java/oracle-jse-jre-i586_1.7.0.bb
> > index 6125025..4165d74 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse-jre-i586_1.7.0.bb
> > +++ b/recipes-devtools/oracle-java/oracle-jse-jre-i586_1.7.0.bb
> > @@ -1,9 +1,9 @@
> > -PR = "r0"
> > -PV_UPDATE = "25"
> > +PR = "r1"
> > +PV_UPDATE = "67"
> >  require oracle-jse-jre.inc
> > -SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u25-b15/jre-7u25-linux-i586.tar.gz"
> > +SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u67-b01/jre-7u67-linux-i586.tar.gz"
> > -SRC_URI[md5sum] = "0e9ccefe49e937e592dbb605f2e8e7d8"
> > -SRC_URI[sha256sum] = "4016965536d8607743267812ab04e6d428036dda432893748c1df6cb77b09628"
> > +SRC_URI[md5sum] = "2a256eb2a91f0084e58c612636342c2b"
> > +SRC_URI[sha256sum] = "eadec83a54d3a9d09248a8d16b21c03da9afffc7317e775fb8db962620a0781d"
> > diff --git a/recipes-devtools/oracle-java/oracle-jse-jre-x86-64_1.7.0.bb b/recipes-devtools/oracle-java/oracle-jse-jre-x86-64_1.7.0.bb
> > index 4058d23..a1474a9 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse-jre-x86-64_1.7.0.bb
> > +++ b/recipes-devtools/oracle-java/oracle-jse-jre-x86-64_1.7.0.bb
> > @@ -1,9 +1,9 @@
> > -PR = "r0"
> > -PV_UPDATE = "25"
> > +PR = "r1"
> > +PV_UPDATE = "67"
> >  require oracle-jse-jre.inc
> > -SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u25-b15/jre-7u25-linux-x64.tar.gz"
> > +SRC_URI = "http://download.oracle.com/otn-pub/java/jdk/7u67-b01/jre-7u67-linux-x64.tar.gz"
> > -SRC_URI[md5sum] = "743ee0ebf73ce428c912866d84e374e0"
> > -SRC_URI[sha256sum] = "3c4496316fb413d5ab0590e9971676a521b9a600b3ceaac311f04c18c98a98c0"
> > +SRC_URI[md5sum] = "9007c79167be0177fb47e5313c53d5cb"
> > +SRC_URI[sha256sum] = "726c37c07bb389b5b96674b7bcbc288e39fb8fbcd42369afa364a18e66248b1f"
> > diff --git a/recipes-devtools/oracle-java/oracle-jse.inc b/recipes-devtools/oracle-java/oracle-jse.inc
> > index 3a4e20d..38ceef0 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse.inc
> > +++ b/recipes-devtools/oracle-java/oracle-jse.inc
> > @@ -2,8 +2,8 @@ LICENSE_FLAGS = "oracle_java"
> > LICENSE = "Oracle_Binary_Code_License_Agreement"
> > LIC_FILES_CHKSUM = "\
> >                file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/LICENSE;md5=98f46ab6481d87c4d77e0e91a6dbc15f \
> > -              file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/COPYRIGHT;md5=3a11238025bf13b87f04753183ffeb90 \
> > -                file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/THIRDPARTYLICENSEREADME.txt;md5=c339b34e3da6673d2c5950d0f8808f8c \
> > +             file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/COPYRIGHT;md5=be9fe5d47a7dcfb78f142f487afb34bb \
> > +                file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/THIRDPARTYLICENSEREADME.txt;md5=f3a388961d24b8b72d412a079a878cdb \
> 
> Please mention in commit message what was changed in it.
> 
> It would be nice to use consistent whitespace for indentation.

I've seen your reply to Khem, but it should be in commit message.

> 
> >                "
> >  FETCHCMD_wget_append = " --header=Cookie:oraclelicense=a "
> > --
> > 2.1.0
> > 
> 
> > -- 
> > _______________________________________________
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
> 
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]