From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Mon, 25 Aug 2014 23:57:20 +0000 Subject: Re: [PATCH v2 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Message-Id: <20140825235720.GB7217@verge.net.au> List-Id: References: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> <1408970132-6690-1-git-send-email-mikhail.ulyanov@cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Mikhail Ulyanov , Magnus Damm , Mauro Carvalho Chehab , Rob Herring , Grant Likely , Mark Rutland , Ian Campbell , Laurent Pinchart , Hans Verkuil , Linux-sh list , Linux Media Mailing List , "devicetree@vger.kernel.org" On Mon, Aug 25, 2014 at 02:59:46PM +0200, Geert Uytterhoeven wrote: > Hi Mikhail, > > On Mon, Aug 25, 2014 at 2:35 PM, Mikhail Ulyanov > wrote: > > + - compatible: should containg one of the following: > > + - "renesas,jpu-r8a7790" for R-Car H2 > > + - "renesas,jpu-r8a7791" for R-Car M2 > > + - "renesas,jpu-gen2" for R-Car second generation > > Isn't "renesas,jpu-gen2" meant as a fallback? > > I.e. the DTS should have one of '7790 and '7791, AND the gen2 fallback, > so we can make the driver match against '7790 and '7791 is we find > out about an incompatibility. Is there a document that clearly states that there is such a thing as jpu-gen2 in hardware? If not I would prefer not to add a binding for it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Date: Tue, 26 Aug 2014 08:57:20 +0900 Message-ID: <20140825235720.GB7217@verge.net.au> References: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> <1408970132-6690-1-git-send-email-mikhail.ulyanov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Mikhail Ulyanov , Magnus Damm , Mauro Carvalho Chehab , Rob Herring , Grant Likely , Mark Rutland , Ian Campbell , Laurent Pinchart , Hans Verkuil , Linux-sh list , Linux Media Mailing List , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Mon, Aug 25, 2014 at 02:59:46PM +0200, Geert Uytterhoeven wrote: > Hi Mikhail, > > On Mon, Aug 25, 2014 at 2:35 PM, Mikhail Ulyanov > wrote: > > + - compatible: should containg one of the following: > > + - "renesas,jpu-r8a7790" for R-Car H2 > > + - "renesas,jpu-r8a7791" for R-Car M2 > > + - "renesas,jpu-gen2" for R-Car second generation > > Isn't "renesas,jpu-gen2" meant as a fallback? > > I.e. the DTS should have one of '7790 and '7791, AND the gen2 fallback, > so we can make the driver match against '7790 and '7791 is we find > out about an incompatibility. Is there a document that clearly states that there is such a thing as jpu-gen2 in hardware? If not I would prefer not to add a binding for it.