From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Tue, 26 Aug 2014 02:42:57 +0000 Subject: Re: [PATCH v2 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Message-Id: <20140826024257.GB17906@verge.net.au> List-Id: References: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> <20140825235720.GB7217@verge.net.au> <2193337.axohMI28rU@avalon> In-Reply-To: <2193337.axohMI28rU@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Geert Uytterhoeven , Mikhail Ulyanov , Magnus Damm , Mauro Carvalho Chehab , Rob Herring , Grant Likely , Mark Rutland , Ian Campbell , Hans Verkuil , Linux-sh list , Linux Media Mailing List , "devicetree@vger.kernel.org" On Tue, Aug 26, 2014 at 02:02:00AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Tuesday 26 August 2014 08:57:20 Simon Horman wrote: > > On Mon, Aug 25, 2014 at 02:59:46PM +0200, Geert Uytterhoeven wrote: > > > On Mon, Aug 25, 2014 at 2:35 PM, Mikhail Ulyanov wrote: > > > > > > > > + - compatible: should containg one of the following: > > > > + - "renesas,jpu-r8a7790" for R-Car H2 > > > > + - "renesas,jpu-r8a7791" for R-Car M2 > > > > + - "renesas,jpu-gen2" for R-Car second generation > > > > > > Isn't "renesas,jpu-gen2" meant as a fallback? > > > > > > I.e. the DTS should have one of '7790 and '7791, AND the gen2 fallback, > > > so we can make the driver match against '7790 and '7791 is we find > > > out about an incompatibility. > > > > Is there a document that clearly states that there is such a thing > > as jpu-gen2 in hardware? If not I would prefer not to add a binding for it. > > How about going the other way around and requesting that document ? Good idea, I will make a request. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Date: Tue, 26 Aug 2014 11:42:57 +0900 Message-ID: <20140826024257.GB17906@verge.net.au> References: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> <20140825235720.GB7217@verge.net.au> <2193337.axohMI28rU@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2193337.axohMI28rU@avalon> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: Geert Uytterhoeven , Mikhail Ulyanov , Magnus Damm , Mauro Carvalho Chehab , Rob Herring , Grant Likely , Mark Rutland , Ian Campbell , Hans Verkuil , Linux-sh list , Linux Media Mailing List , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Tue, Aug 26, 2014 at 02:02:00AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Tuesday 26 August 2014 08:57:20 Simon Horman wrote: > > On Mon, Aug 25, 2014 at 02:59:46PM +0200, Geert Uytterhoeven wrote: > > > On Mon, Aug 25, 2014 at 2:35 PM, Mikhail Ulyanov wrote: > > > > > > > > + - compatible: should containg one of the following: > > > > + - "renesas,jpu-r8a7790" for R-Car H2 > > > > + - "renesas,jpu-r8a7791" for R-Car M2 > > > > + - "renesas,jpu-gen2" for R-Car second generation > > > > > > Isn't "renesas,jpu-gen2" meant as a fallback? > > > > > > I.e. the DTS should have one of '7790 and '7791, AND the gen2 fallback, > > > so we can make the driver match against '7790 and '7791 is we find > > > out about an incompatibility. > > > > Is there a document that clearly states that there is such a thing > > as jpu-gen2 in hardware? If not I would prefer not to add a binding for it. > > How about going the other way around and requesting that document ? Good idea, I will make a request.