From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMEEz-0007UN-Dd for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMEEt-0001UO-No for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:44:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMEEt-0001UA-GW for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:44:35 -0400 Date: Tue, 26 Aug 2014 11:44:26 +0100 From: Stefan Hajnoczi Message-ID: <20140826104426.GB11279@stefanha-thinkpad.redhat.com> References: <20140728084846.GH31917@G08FNSTD100614.fnst.cn.fujitsu.com> <20140822105429.GF32377@noname.redhat.com> <20140825013515.GD15478@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Content-Disposition: inline In-Reply-To: <20140825013515.GD15478@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Kevin Wolf , Yasunori Goto , qemu-devel@nongnu.org, Max Reitz --+g7M9IMkV8truYOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 25, 2014 at 09:35:15AM +0800, Hu Tao wrote: > On Fri, Aug 22, 2014 at 12:54:29PM +0200, Kevin Wolf wrote: > > Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > > > ping... > > >=20 > > > All the 6 patches have reviewed-by now. > >=20 > > Looks mostly good to me, I have only a few minor comments that wouldn't > > block inclusion but could be addressed in follow-up patches. > >=20 > > However, you have a dependency on a patch series from Max (you use > > minimal_blob_size()), which hasn't been reviewed and merged yet, so your > > series is blocked on that. > >=20 > > If you want to get your series merged quicker, you could replace this > > with a rough estimate that excludes the clusters used by refcount table > > and blocks. If full preallocation isn't really full, but only > > preallocation of 99.9%, that's probably good enough in practice. >=20 > How about my calculation in v10? > https://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg02844.html >=20 > It doesn't depend on minimal_blob_size(). In most cases the calculated > size is the same as the size before this patch. I have no test results > on hand, but if you need I can do it. Kevin is on vacation this week. I think the previous calculation could work. Stefan --+g7M9IMkV8truYOl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/GUKAAoJEJykq7OBq3PIsuYH/3AzxkcaoLhhhUxszhoFfWlY 8TMG1J0WgG6qte9UrFA1dSNlmxQX1JWREUQoN5uCklCMT933SnkfP1m2mUW2iHEW W0Pilgw1ILEu1hSAnR8DmzpZRaGxhjMKdhYGJeaqX3LRJbun3JQm1jKFn6dscH1n Cb9xt6qRNtmJDRxZVci25RN4KaoMohm315NApee0f1fQnrBdS5I5uKDXYC8QUgZu pbqeWOGVFp4jLcMb8CH1kKprRa0iLN6RfKRbXJJXI4y3LWRgBPZyJhSR1lnRKnKR m8KGu/TOI/jzdbchDLmtuHhy9Jt7GYUoCGd3Toh3l+OO+J+ybP329fCR3nYPs98= =3uKj -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl--