From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMELX-0000kF-BC for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMELO-000464-0U for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:51:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMELN-00045n-Nk for qemu-devel@nongnu.org; Tue, 26 Aug 2014 06:51:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7QApGKO018386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Aug 2014 06:51:17 -0400 Date: Tue, 26 Aug 2014 11:51:15 +0100 From: Stefan Hajnoczi Message-ID: <20140826105115.GC11279@stefanha-thinkpad.redhat.com> References: <1408102357-914-1-git-send-email-armbru@redhat.com> <1408102357-914-3-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2/5bycvrmDh4d1IB" Content-Disposition: inline In-Reply-To: <1408102357-914-3-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] ide: Fix bootindex for bus_id > 9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com --2/5bycvrmDh4d1IB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 15, 2014 at 01:32:37PM +0200, Markus Armbruster wrote: > We identify devices by their Open Firmware device paths. The encoding > of bus numbers is incorrect: idebus_get_fw_dev_path() formats them in > decimal, while SeaBIOS uses hexadecimal. With bus number > 9, SeaBIOS > will miss the bootindex (lucky case), or apply it to another device > (unlucky case). >=20 > Bug can't bite right now: ich9-ahci has six ports, and the sysbus-ahci > created by Calxeda Highbank has just one. >=20 > Fix it anyway, by changing %d to %x. >=20 > I couldn't find an Open Firmware spec covering this. For what it's > worth, OVMF agrees with SeaBIOS. >=20 > Signed-off-by: Markus Armbruster > --- > hw/ide/qdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --2/5bycvrmDh4d1IB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/GajAAoJEJykq7OBq3PI41MH/iKRaqnBwBD7MhTQL8whVaZ8 VPb74f+mipFT8V66MDi2HN7RAXJIxMA4pwTkeZp5dZo51C/vy1OBB8XbajWsV6FC peoEaUX5yJGSQRTWZD+mBeccJTZXu2RXfzf5/g9xmsfRPSjH2y8WPcjLUPTulfsC yBV+S5+lVVscjDu04oPZ9klpxx4C7cGLT44OyI8vuMyX4sysLKFPm+pIUOC7dMzM tuy3ekTRlmISIRnfrS/tsCwA66+5W0SQPExUwT6nqYpC6sEAXCeoHv+BS/p4QGMU PgHSj52eBZntkEfa5XsCPQIAb5evO9UTKXTDMLwG+Eigfi6NrdxwggeMHJY/S98= =PQjT -----END PGP SIGNATURE----- --2/5bycvrmDh4d1IB--