From: Martin Jansa <martin.jansa@gmail.com>
To: Christopher Larson <kergoth@gmail.com>
Cc: Christopher Larson <chris_larson@mentor.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2 1/3] sanity: handle both \n and \\n in mirror vars
Date: Tue, 26 Aug 2014 12:59:15 +0200 [thread overview]
Message-ID: <20140826105915.GW20524@jama> (raw)
In-Reply-To: <20140826105149.GV20524@jama>
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
On Tue, Aug 26, 2014 at 12:51:49PM +0200, Martin Jansa wrote:
> On Mon, Aug 25, 2014 at 03:57:42PM -0700, Christopher Larson wrote:
> > From: Christopher Larson <chris_larson@mentor.com>
> >
> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > ---
> > meta/classes/sanity.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > index dbcc26b..7cfc4be 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -759,7 +759,7 @@ def check_sanity_everybuild(status, d):
> > 'git://', 'gitsm://', 'hg://', 'osc://', 'p4://', 'svk://', 'svn://', \
> > 'bzr://', 'cvs://']
> > for mir_type in mir_types:
> > - mirros = (d.getVar(mir_type, True) or '').split('\\n')
> > + mirros = (d.getVar(mir_type, True) or '').replace('\\n', '\n').split('\n')
>
> Would you mind fixing the typo in variable name as well?
Nevermind, it's refactored in 3/3, sorry for noise.
> > for mir in mirros:
> > mir_list = mir.split()
> > # Should be two members.
> > --
> > 1.8.3.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2014-08-26 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 22:46 [PATCH 0/3] sanity: improve mirrors check Christopher Larson
2014-08-25 22:46 ` [PATCH 1/3] sanity: handle both \n and \n in mirror vars Christopher Larson
2014-08-25 22:50 ` Christopher Larson
2014-08-25 22:46 ` [PATCH 2/3] sanity: fix support for regex schemes in mirrors check Christopher Larson
2014-08-25 22:46 ` [PATCH 3/3] sanity: refactor mirrors checks to be more pythonic Christopher Larson
2014-08-25 22:57 ` [PATCHv2 0/3] sanity: improve mirrors check Christopher Larson
2014-08-25 22:57 ` [PATCHv2 1/3] sanity: handle both \n and \\n in mirror vars Christopher Larson
2014-08-26 10:51 ` Martin Jansa
2014-08-26 10:59 ` Martin Jansa [this message]
2014-08-27 11:50 ` Koen Kooi
2014-08-25 22:57 ` [PATCHv2 2/3] sanity: fix support for regex schemes in mirrors check Christopher Larson
2014-08-25 22:57 ` [PATCHv2 3/3] sanity: refactor mirrors checks to be more pythonic Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826105915.GW20524@jama \
--to=martin.jansa@gmail.com \
--cc=chris_larson@mentor.com \
--cc=kergoth@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.