From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/7] drm: Renaming DP training vswing pre emph defines Date: Tue, 26 Aug 2014 13:28:19 +0200 Message-ID: <20140826112818.GA31534@ulmo> References: <1407495226-12620-1-git-send-email-sonika.jindal@intel.com> <1407495226-12620-2-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0966420930==" Return-path: In-Reply-To: <1407495226-12620-2-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sonika.jindal@intel.com Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0966420930== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jindal@intel.com wrote: > From: Sonika Jindal >=20 > Adding new defines, older one will be removed in the last patch in the se= ries. > This is to rename the defines to have levels instead of values for vswing= and > pre-emph levels as the values may differ in other scenarios like low vswi= ng of > eDP1.4 where the values are different. >=20 > Done using following cocci patch for each define: > @@ > @@ >=20 > # define DP_TRAIN_VOLTAGE_SWING_400 (0 << 0) > + # define DP_TRAIN_VOLTAGE_SWING_LEVEL_0 (0 << 0) Could this perhaps be simply: #define DP_TRAIN_VOLTAGE_SWING(x) ((x) << 0) As it is, there's no information about the value within the symbolic name anyway, so _LEVEL_* really isn't that useful and keeping several macros for each value seems isn't either. An alternative would be to provide a second set of defines for eDP 1.4 where the name implies the meaning and then use them as appropriate. Thierry --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT/G9SAAoJEN0jrNd/PrOhEDkP/ibKVrgl6IcqKsPh59m7vkD+ fPfpJrO0Mb5y5Ziy52rqp0oJ3KOMnqLPRgvuvg8x5BJ9EN+Z+aBImwl4Enx2IAIT 3UC6/km/OYcGFpR4MmNNNOfk1nEdMOrk4Sgbo5Y4b0SstVti/EnK8SJN78ZJclOI kr86bqWbT94Oi7znVOWS39SweWcRo8AzPSq+xv6/fNa3azgtasAJ5rfOgQgi4BSh ZIjLLphOyUmPNDYOr8zCMU+0fGnXBGD/yLdHF5ytWt0zfB4EEK0zTJJyDJiR/ZiJ 0WFzLQXxqKYvMd8cr3Vj+1OzmJopGq7Y6VmcEP8WGOLU+MpsstVrm2ZzRfVXboyI 6i5d6SMD/Ho5hQPHmr5kH5utMkw8p9PiwZBuC9ShzZjf3+G1dobNo3bb5WFdyqV6 6pWKyNFzT/JwWplvnfdTjWn61prvE5pQEiY6UTH27Fqu9oqZpP8fcELtsVMrWQh4 gTWZJkSf6R6op5nGmBIXuXX84B46KQ3P2/41xI5XwyEYI6gQc2JjdoKkBjlVzN48 GsTe/0LDb4I6bKILSz0W5VO6GZ9C2hGMAhYTJ0Baomtso6gJyHVovnRi7dfdb3eU ekMh/uRyoJV9AoEQ5xba4IfZC7lZ9Rsd6ka1KMqibEdKc2EqDLI6/fyOY9kjsgQA tilSsTqahyUr2wJ29h2z =GKfK -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/-- --===============0966420930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0966420930==--