From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Date: Wed, 27 Aug 2014 12:09:28 +0100 Message-ID: <20140827110927.GC7773@leverpostej> References: <1409132660-1898-1-git-send-email-ch.naveen@samsung.com> <1409132660-1898-5-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1409132660-1898-5-git-send-email-ch.naveen@samsung.com> Content-Language: en-US Sender: linux-samsung-soc-owner@vger.kernel.org To: Naveen Krishna Chatradhi Cc: Catalin Marinas , "naveenkrishna.ch@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "cpgs@samsung.com" , Alim Akhtar , Rob Herring List-Id: devicetree@vger.kernel.org Hi, On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: > From: Alim Akhtar > > This patch adds the necessary Kconfig entries to enable > support for the ARMv8 based Exynos7 SoC. > > Signed-off-by: Alim Akhtar > Signed-off-by: Naveen Krishna Chatradhi > Cc: Rob Herring > Cc: Catalin Marinas > --- > arch/arm64/Kconfig | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index fd4e81a..d555558 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer" > > menu "Platform selection" > > +config ARCH_EXYNOS7 > + bool "ARMv8 based SAMSUNG EXYNOS7" > + select HAVE_S3C2410_WATCHDOG if WATCHDOG > + select CLKSRC_OF This seems to be implied by ARM_ARCH_TIMER in the core arm64 Kconfig, so I'm not sure this is necessary. > + select COMMON_CLK_SAMSUNG > + select GPIOLIB You select ARCH_REQUIRE_GPIOLIB below, so is this necessary? > + select PINCTRL > + select PINCTRL_EXYNOS > + select RTC_CLASS > + select HAVE_S3C_RTC > + select GENERIC_GPIO > + select ARCH_REQUIRE_GPIOLIB > + select HAVE_CLK Isn't this selected already through the core arm64 Kconfig? It looks like we have COMMON_CLK, which selects CLKDEV_LOOKUP, which selects HAVE_CLK. > + select HAVE_SMP I may have missed something, but I didn't see any SMP support in this series. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Wed, 27 Aug 2014 12:09:28 +0100 Subject: [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support In-Reply-To: <1409132660-1898-5-git-send-email-ch.naveen@samsung.com> References: <1409132660-1898-1-git-send-email-ch.naveen@samsung.com> <1409132660-1898-5-git-send-email-ch.naveen@samsung.com> Message-ID: <20140827110927.GC7773@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: > From: Alim Akhtar > > This patch adds the necessary Kconfig entries to enable > support for the ARMv8 based Exynos7 SoC. > > Signed-off-by: Alim Akhtar > Signed-off-by: Naveen Krishna Chatradhi > Cc: Rob Herring > Cc: Catalin Marinas > --- > arch/arm64/Kconfig | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index fd4e81a..d555558 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer" > > menu "Platform selection" > > +config ARCH_EXYNOS7 > + bool "ARMv8 based SAMSUNG EXYNOS7" > + select HAVE_S3C2410_WATCHDOG if WATCHDOG > + select CLKSRC_OF This seems to be implied by ARM_ARCH_TIMER in the core arm64 Kconfig, so I'm not sure this is necessary. > + select COMMON_CLK_SAMSUNG > + select GPIOLIB You select ARCH_REQUIRE_GPIOLIB below, so is this necessary? > + select PINCTRL > + select PINCTRL_EXYNOS > + select RTC_CLASS > + select HAVE_S3C_RTC > + select GENERIC_GPIO > + select ARCH_REQUIRE_GPIOLIB > + select HAVE_CLK Isn't this selected already through the core arm64 Kconfig? It looks like we have COMMON_CLK, which selects CLKDEV_LOOKUP, which selects HAVE_CLK. > + select HAVE_SMP I may have missed something, but I didn't see any SMP support in this series. Thanks, Mark.