All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Alexander Graf <agraf@suse.de>
Cc: benh@au1.ibm.com, aik@au1.ibm.com, qemu-devel@nongnu.org,
	qemu-ppc@nongnu.org,
	Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
	paulus@samba.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob
Date: Fri, 29 Aug 2014 13:47:21 +1000	[thread overview]
Message-ID: <20140829034721.GE1930@voom.redhat.com> (raw)
In-Reply-To: <53FFAAC4.2050408@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

On Fri, Aug 29, 2014 at 12:18:44AM +0200, Alexander Graf wrote:
> 
> 
> On 28.08.14 20:20, Aravinda Prasad wrote:
> > 
> > 
> > On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote:
> >>
> >>
> >> On 25.08.14 15:45, Aravinda Prasad wrote:
> >>> Extend rtas-blob to accommodate error log. Error log
> >>> structure is saved in rtas space upon a machine check
> >>> exception.
> >>>
> >>> Signed-off-by: Aravinda Prasad <aravinda@linux.vnet.ibm.com>
> >>
> >> I can't say I'm a big fan of this patch. Can we somehow separate that
> >> NMI page from the RTAS blob? Also I'd definitely prefer if we keep
> >> rtas_entry == rtas_addr - if nothing else for the sake of backwards
> >> compatibility.
> >>
> >> So how about we lay out the structure in memory like this:
> >>
> >>   [ spapr-rtas.bin ]
> >>   [ padding to 4k boundary or whatever sPAPR requires ]
> >>   [ 4k NMI region ]
> >>
> >> Then the only thing we'd have to really change internally is the size
> >> information of the rtas blob.
> > 
> > Either we can have it like this or completely eliminate spapr-rtas.bin
> > (and spapr-rtas.S) by simply allocating required space in QEMU and then
> > patching the 5 instructions at rtas-entry as earlier discussed with David.
> > 
> > http://lists.nongnu.org/archive/html/qemu-ppc/2014-08/msg00251.html
> > 
> 
> I strongly disagree with David. Legally there is no difference between a
> .bin file that contains code and an array made of instructions. And the
> more target code we can keep outside of QEMU the better.

What do legalities have to do with it?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-08-29  4:36 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 13:45 [Qemu-devel] [PATCH 0/5] target-ppc: Add FWNMI support in QEMU for powerKVM guests Aravinda Prasad
2014-08-25 13:45 ` [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob Aravinda Prasad
2014-08-26  5:38   ` David Gibson
2014-08-26  6:34     ` Aravinda Prasad
2014-08-26  7:24       ` David Gibson
2014-08-28 10:40   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-08-28 18:20     ` Aravinda Prasad
2014-08-28 22:18       ` Alexander Graf
2014-08-28 22:25         ` Benjamin Herrenschmidt
2014-08-29  0:40           ` Alexander Graf
2014-08-29  1:06             ` Benjamin Herrenschmidt
2014-08-29  1:33               ` Alexander Graf
2014-08-29  2:42                 ` Benjamin Herrenschmidt
2014-08-29  3:46                 ` David Gibson
2014-08-29  3:47         ` David Gibson [this message]
2014-09-01  7:46   ` [Qemu-devel] " Alexey Kardashevskiy
2014-09-01 11:23     ` Aravinda Prasad
2014-09-02  4:09       ` Alexey Kardashevskiy
2014-09-02  5:25         ` Aravinda Prasad
2014-09-02  5:49           ` Alexey Kardashevskiy
2014-09-02  5:56             ` Aravinda Prasad
2014-09-02  6:34               ` Alexey Kardashevskiy
2014-09-02  7:07                 ` Aravinda Prasad
2014-09-02  8:40                   ` Alexey Kardashevskiy
2014-09-02  9:30                     ` Aravinda Prasad
2014-09-02 13:17                       ` Alexey Kardashevskiy
2014-08-25 13:45 ` [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region Aravinda Prasad
2014-08-26  5:39   ` David Gibson
2014-08-26  6:15     ` Benjamin Herrenschmidt
2014-08-26  7:24       ` David Gibson
2014-08-26 20:05         ` Benjamin Herrenschmidt
2014-08-25 13:45 ` [Qemu-devel] [PATCH 3/5] target-ppc: Build error log Aravinda Prasad
2014-08-26  5:47   ` David Gibson
2014-08-26  6:40     ` Aravinda Prasad
2014-08-27  9:50   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-08-28  6:12     ` Aravinda Prasad
2014-08-28  8:36       ` Alexander Graf
2014-08-28 10:21         ` Benjamin Herrenschmidt
2014-08-28 10:29           ` Alexander Graf
2014-08-28 10:33             ` Benjamin Herrenschmidt
2014-08-28 10:34               ` Benjamin Herrenschmidt
2014-08-28 17:17               ` Aravinda Prasad
2014-08-28 20:07                 ` Benjamin Herrenschmidt
2014-08-30  8:06                   ` Aravinda Prasad
2014-08-25 13:45 ` [Qemu-devel] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call Aravinda Prasad
2014-08-26  6:02   ` David Gibson
2014-08-26  6:57     ` Aravinda Prasad
2014-08-27 10:37   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-08-28  6:38     ` Aravinda Prasad
2014-08-28  8:37       ` Alexander Graf
2014-08-28 13:06         ` Tom Musta
2014-08-28 13:11           ` Alexander Graf
2014-08-28 17:42         ` Aravinda Prasad
2014-08-28 22:16           ` Alexander Graf
2014-08-30  8:08             ` Aravinda Prasad
2014-09-04  8:25             ` Aravinda Prasad
2014-09-04 13:09               ` Alexander Graf
2014-09-04 13:49                 ` Aravinda Prasad
2014-09-05  8:46                   ` Alexander Graf
2014-09-05  8:52                     ` Aravinda Prasad
2014-09-07 20:47   ` Alexander Graf
2014-09-26  3:58     ` Alexey Kardashevskiy
2014-10-06  6:32     ` Aravinda Prasad
2014-10-06  9:40       ` Alexander Graf
2014-10-06 11:01         ` Aravinda Prasad
2014-08-25 13:45 ` [Qemu-devel] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check Aravinda Prasad
2014-08-26  6:04   ` David Gibson
2014-08-26  7:04     ` Aravinda Prasad
2014-08-27 10:40   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-08-28  6:56     ` Aravinda Prasad
2014-08-28  8:39       ` Alexander Graf
2014-08-28  8:42       ` Alexander Graf
2014-08-28 17:45         ` Aravinda Prasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140829034721.GE1930@voom.redhat.com \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@au1.ibm.com \
    --cc=aravinda@linux.vnet.ibm.com \
    --cc=benh@au1.ibm.com \
    --cc=paulus@samba.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.