From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 02/20] drm: mark drm_buf and drm_map as legacy Date: Fri, 29 Aug 2014 13:32:03 +0200 Message-ID: <20140829113202.GB17519@ulmo> References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com> <1409307166-12396-3-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0728565844==" Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F42C6E0D5 for ; Fri, 29 Aug 2014 04:32:06 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id d1so8922829wiv.13 for ; Fri, 29 Aug 2014 04:32:05 -0700 (PDT) In-Reply-To: <1409307166-12396-3-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0728565844== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MfFXiAuoTsnnDAfZ" Content-Disposition: inline --MfFXiAuoTsnnDAfZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 12:12:28PM +0200, David Herrmann wrote: > Move internal declarations to drm_legacy.h and add drm_legacy_*() prefix > to all legacy functions. Perhaps this could give a short explanation of why they are marked as legacy and what the plan is to get rid of them. [...] > diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c [...] > @@ -378,7 +374,7 @@ int drm_addmap(struct drm_device * dev, resource_size= _t offset, > return rc; > } > =20 > -EXPORT_SYMBOL(drm_addmap); > +EXPORT_SYMBOL(drm_legacy_addmap); Nit: might as well remove the unusual blank line between the closing brace and the EXPORT_SYMBOL while at it. > diff --git a/drivers/gpu/drm/mga/mga_dma.c b/drivers/gpu/drm/mga/mga_dma.c [...] > offset =3D 0; > - err =3D drm_addmap(dev, offset, warp_size, > - _DRM_AGP, _DRM_READ_ONLY, &dev_priv->warp); > + err =3D drm_legacy_addmap(dev, offset, warp_size, > + _DRM_AGP, _DRM_READ_ONLY, &dev_priv->warp); The parameters are somewhat oddly wrapped here. Nothing that the patch introduces, but perhaps low-hanging fruit while at it. There are a few other occurrences in this file. I found only minor whitespace nits, feel free to ignore those. Reviewed-by: Thierry Reding --MfFXiAuoTsnnDAfZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBAgAGBQJUAGSyAAoJEN0jrNd/PrOh1IgP+OzvkUMfdXYnU74apCRRmk71 3VDGj17+ec02yGdvlV1C/jnfgEOmxYtmqZCB3rF1cOwIGbwUftFizMiqjNnnB60h J6KioK7G7T9zwfQJO9dt9wcDNfiFukHXSMPo7v61bXZpV9KnX2aQ75AE1Wc/+QVI +Avw0r+HpAVwdJwsYUbaTRS4wjNIHKCXejqLBcGgsFEd16pWEaZjvVTeVNIGTTj8 8h8dgGeSIn+pc+m5OrL7HuYNcKMu7PMp7T8I9ph+uws1ExakIOMlAxSUKBkopKI4 Cv3fTPijW8RHUDkayXSa0tAK6LJV5mJaSPm5BxSn7Z9nEdsHiEwD/K8eR/lqZg/c ylK+VoM/S+4jHpwtbquyCX6EfSqS7qdju6oRVwu7ZTi4EGP2NUVN/n4pDf1xp9sS rSWDMrqUDJB288wkYhd5dfGF3nqK3rvs+8qAcAoB0pw2uJEYwJsGIsU85++nhuql 3YgFJjXzIyoMoMYcC2F7tUKFLm1CkKglZ2pLmFrTq7hfbrJIFGFir5JrmJDEI4Yy WAU2vPzuCKMM5DcYsZ5Bw1pzarX4uqzcHBadbnIufPT+Vz1LENGzF5F/Tc0dr94W e1haNgraPuA8B9O70ezGHMhdXX4HHYElhqGnfNbPDo5fI1fCLq29rvqhisnaPc2j dkvma4WfghETGnvb+Qo= =Xmvt -----END PGP SIGNATURE----- --MfFXiAuoTsnnDAfZ-- --===============0728565844== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0728565844==--