From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 04/20] drm: move "struct drm_magic_entry" to drm_auth.c
Date: Fri, 29 Aug 2014 13:39:29 +0200
Message-ID: <20140829113928.GD17519@ulmo>
References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com>
 <1409307166-12396-5-git-send-email-dh.herrmann@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1623006001=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181])
 by gabe.freedesktop.org (Postfix) with ESMTP id 877796E305
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Aug 2014 04:39:32 -0700 (PDT)
Received: by mail-wi0-f181.google.com with SMTP id e4so2381410wiv.2
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Aug 2014 04:39:31 -0700 (PDT)
In-Reply-To: <1409307166-12396-5-git-send-email-dh.herrmann@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============1623006001==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl"
Content-Disposition: inline


--jCrbxBqMcLqd4mOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 29, 2014 at 12:12:30PM +0200, David Herrmann wrote:
> In drm_release(), we currently call drm_remove_magic() if the drm_file
> has a drm-magic attached. Therefore, once drm_master_release() is called,
> the magic-list _must_ be empty.
>=20
> By dropping the no-op cleanup, we can move "struct drm_magic_entry" to
> drm_auth.c and avoid exposing it to all of DRM.
>=20
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> ---
>  drivers/gpu/drm/drm_auth.c | 6 ++++++
>  drivers/gpu/drm/drm_drv.c  | 7 -------
>  include/drm/drmP.h         | 6 ------
>  3 files changed, 6 insertions(+), 13 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--jCrbxBqMcLqd4mOl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUAGZwAAoJEN0jrNd/PrOhsK0QAJvsITYHbM7LMbjJEd9Zu4Gi
47H2VfJbBPOvqEsHlakVApBviX4/IaQ4dqo/qAtWVBjNeEA5SEOHKSwU42rVROq4
LBosayHHnpkqOGLb0DPN6wLWD6bIKNxnyE3Hpsc42zxSwwZL8MqkPGSGQ+gnZ80r
yeYV4Hcv2gpvcM4LdvkN7BTbZCkkhaLCCRir7MDYSB695y8DCunOculJN2ge1ugA
wPuHai/jZNSf6TEf51BoQpg3pa2wLReLc48pMX1HHcBwknh/rZW0S+k3i3bSI06P
GEZDdQFBQM3BaA3755Lx0lZrMKdq2vuWXv7bJwbfQprnPgZCK6rYjM1v0oaP0gsp
qdsgX8AlpcKCy1ydxU9xrHMwQYZX5HqFtDeO32smndtPx7W2itg69t6yvOjGfqWv
4KnK5saUZ1vJW5r2Ad/ATh/zu+xKTMDY0h0YOotOXGxOGa7zDj3qMII338eVVIZy
NGS1vFkJVQnBJrZMVuZZ2yLDRZayRsIIXLizWSqGaHoRtycQGUIZBRf0h0433yE/
WnzNNyEgkquD8q9pwk4sV3lxge6x6B/LywOX/mI5O32bDEMUMFxrSFg6CM7vWF2Y
LPhATtppARPUVkYEIb9HQdai517Zwr5U3gExFXMbSulHu2/qv4yeZJrBd55KgV32
c3SXkshX6pVhaWtmOR99
=wFqc
-----END PGP SIGNATURE-----

--jCrbxBqMcLqd4mOl--

--===============1623006001==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--===============1623006001==--