On Fri, Aug 29, 2014 at 12:12:37PM +0200, David Herrmann wrote: > It is hardly possible to review the drmP.h includes, anymore. Order them > alphabetically, linux/ first, then asm/ and then local drm/ includes. > > Since a long time ago, kernel headers have been converted to include > required headers themselves. No-one cares whether that means the compiler > has to include a header multiple times. In fact, GCC already does some > optimization regarding multiple inclusions if a sorrounding #ifndef is > present. > > Signed-off-by: David Herrmann > --- > include/drm/drmP.h | 46 +++++++++++++++++++++++----------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) This looks good, but I don't think I'm going to bother manually checking each of those. Provided everything still complies, this is at least: Acked-by: Thierry Reding