From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 11/20] drm: order includes alphabetically in drmP.h Date: Fri, 29 Aug 2014 14:05:17 +0200 Message-ID: <20140829120511.GK17519@ulmo> References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com> <1409307166-12396-12-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0502591873==" Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 147906E6C5 for ; Fri, 29 Aug 2014 05:05:19 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id d1so8978622wiv.7 for ; Fri, 29 Aug 2014 05:05:19 -0700 (PDT) In-Reply-To: <1409307166-12396-12-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0502591873== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Z1OTrj3C7qypP14j" Content-Disposition: inline --Z1OTrj3C7qypP14j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 12:12:37PM +0200, David Herrmann wrote: > It is hardly possible to review the drmP.h includes, anymore. Order them > alphabetically, linux/ first, then asm/ and then local drm/ includes. >=20 > Since a long time ago, kernel headers have been converted to include > required headers themselves. No-one cares whether that means the compiler > has to include a header multiple times. In fact, GCC already does some > optimization regarding multiple inclusions if a sorrounding #ifndef is > present. >=20 > Signed-off-by: David Herrmann > --- > include/drm/drmP.h | 46 +++++++++++++++++++++++----------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) This looks good, but I don't think I'm going to bother manually checking each of those. Provided everything still complies, this is at least: Acked-by: Thierry Reding --Z1OTrj3C7qypP14j Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUAGx3AAoJEN0jrNd/PrOhU5QP/2xM4l4KENx/eqbQ1BoUZnPj iGMbKesTo7yuJrd8GrupgMj979ofkPTMggP3rVG+/LBca8knZyLS5InKJB8d4zNl n4pbgdKdfiu8wtvGTV8ynxfPXl3ULpii23x0CurS9+nZWs/XNTq15BLD/Vivve/H QNQHrWrkWrqyNqjKTCisnog1q8VJP0/MRcFsQk/Hm5llX3I3BF4OAtIlfjZrWahw 61LBSI7uG7blb2LqkqZY9LZ4HOg5YDEJiuQtvLjm249D8jTXAT84rpuVJS06BTt2 H1rswWUMNyM3fzg7jZHG6MoJfjGDPSGObLf7Xz4Y0rC2jwLQvkC24/WtmlfKMDcu OGaWNG1sqFCNfI/eCY4yK4dJcoaoRuILOKrDTKnlLkLKdafYSN4ogme1we3btopo Voi0ZXorVY5YIYaTd6gud3ShSrLWYbWr5xC/YWSm4G4g069QFnqb7lVBRTeqx+DB H8SpSHVtgcDv0/U/z4YeYZtwoSfT/29Yvg9irbnGaVq2j45djDqvKD6lqg7eQwIE NMxpuuYvLJggyGhwyfrBHSHymFfYRTlk/b4Mem5t7j8clyXQeEDfeY2Q6C9vd9Ea 4AppL9O4ODrmk7cJRmihGVXuaY6Ix99C6OflSbR6LNwa02RUrikpEVsou8GXVyjn ZVRL7Mm3ygH9n3EFmw2Y =9hGf -----END PGP SIGNATURE----- --Z1OTrj3C7qypP14j-- --===============0502591873== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0502591873==--