From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 13/20] drm: inline "struct drm_sigdata" Date: Fri, 29 Aug 2014 14:21:40 +0200 Message-ID: <20140829122126.GM17519@ulmo> References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com> <1409307166-12396-14-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2015448975==" Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 404CB6E6BE for ; Fri, 29 Aug 2014 05:21:43 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id p10so2100733wes.1 for ; Fri, 29 Aug 2014 05:21:42 -0700 (PDT) In-Reply-To: <1409307166-12396-14-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2015448975== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AA9g+nFNFPYNJKiL" Content-Disposition: inline --AA9g+nFNFPYNJKiL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 12:12:39PM +0200, David Herrmann wrote: > The sigdata structure is only used to group two fields in drm_device. > Inline it and make it an unnamed object. I'm not sure what unnamed object means. > diff --git a/include/drm/drmP.h b/include/drm/drmP.h [...] > @@ -1035,9 +1029,13 @@ struct drm_device { > =20 > struct drm_sg_mem *sg; /**< Scatter gather memory */ > unsigned int num_crtcs; /**< Number of CRTCs on this d= evice */ > - struct drm_sigdata sigdata; /**< For block_all_signals */ > sigset_t sigmask; > =20 > + struct { > + int context; Your patch doesn't introduce this, but shouldn't context here be unsigned given that it's compared to drm_hw_lock's .lock field? I guess struct drm_lock could have that same change. I suppose it might not be all that important since presumably the code works, but it's still inconsistent use of types. Anyway, if you could clarify the "unnamed object" in the commit description, this patch: Reviewed-by: Thierry Reding --AA9g+nFNFPYNJKiL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUAHBGAAoJEN0jrNd/PrOh2p8P/0nblKtnJuHROPpxD++0Myf9 nKi8l+mKfo+Xzro0z/NyRQBMc5tgBDXAhArFqdryw2S6ipaPMMN+lB78oLiP798q XA3Bs/kaaeg7s3kXV80CocPPSo0hRWBk/iplhsJamkGg2yz1egaa5Cth3Kc1Gky5 TrzE0ZS9JxiIjjl1pHlUqfJWmu3XIOwkrWxO9XGEELCuOaCe60ucToeilvWm6Dp3 uHB6UUSn2Sz5tmSUO8cAoMQvwAW+nv3/CxAzP/Q0O0F8COyz6xZRyaqvkjQxrLDw i4yjxGhOpUkOfqI5ePFXXMMR/y+oUfXiHqubXaQ4bfAEHNc/ax7zgRm2/6E2ptoc fA6U8e7+8qOt+dJkvaBqI7tRQrHHAQOAX5OC4DO0c+IUCjpRhw+/xMifa7sm3MDt TR/GbAFVod/jfUVorwkiuD6xFqfualCpC+WtCLO++VSlLbfvdwor39wevT+hzMoe iXisRhqyKCQmXompOqh3IvegYHylpmUDgjDd8N4Toh1ED0iME20+A0VUwthMcs9a vDDLWz+cKoePfycRcBXZN1WYvFm0p4WOhB85mBc9F4LOvaHUl7TccxRHr7FN522a 8sRKtpgCpBVDG6XyKueEEBw2ZN2tAEiZuocF2ZosViVqLQcVzc8+SwUiRxsbjvL5 INyvoZO4QV3bNzvCy7vO =awcd -----END PGP SIGNATURE----- --AA9g+nFNFPYNJKiL-- --===============2015448975== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2015448975==--