From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 19/20] drm: merge drm_usb into udl
Date: Fri, 29 Aug 2014 15:00:47 +0200
Message-ID: <20140829130042.GS17519@ulmo>
References: <1409307166-12396-1-git-send-email-dh.herrmann@gmail.com>
 <1409307166-12396-20-git-send-email-dh.herrmann@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1456564438=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-we0-f178.google.com (mail-we0-f178.google.com
 [74.125.82.178])
 by gabe.freedesktop.org (Postfix) with ESMTP id 253DC6E6EA
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Aug 2014 06:00:52 -0700 (PDT)
Received: by mail-we0-f178.google.com with SMTP id u57so2115986wes.23
 for <dri-devel@lists.freedesktop.org>; Fri, 29 Aug 2014 06:00:50 -0700 (PDT)
In-Reply-To: <1409307166-12396-20-git-send-email-dh.herrmann@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============1456564438==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="AonAANj1daC6QcQu"
Content-Disposition: inline


--AonAANj1daC6QcQu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 29, 2014 at 12:12:45PM +0200, David Herrmann wrote:
[...]
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
[...]
>  module_init(udl_init);
>  module_exit(udl_exit);
> +MODULE_LICENSE("GPL");

According to the header file the license is GPL v2 only, so this should
be "GPL v2".

Might also be good to add MODULE_AUTHOR and MODULE_DESCRIPTION here.

Other than that:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--AonAANj1daC6QcQu
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUAHl6AAoJEN0jrNd/PrOh570P/RioonnaQGrb7G7VB6L4r4G4
DPDFzrRDYlIDlY3BhU3gQ145IXm+TiuilXemY57Bz7obrV4uPXXqKa/fdWj+sUdy
KNqkzMXevaeCMTabZmgEeB2zRh2cPOblNPIcg+a6IBl7mG0NQrNlT8BT93degEkT
TJfcLHVsCM8LRLzj3lNW2+zz/G2yCmUI/a0xPDpzREAegpK7DDL404bi7Ej7GNvo
LPSHdeSTAOvWs6Wf0uHUo6duzWcf8VIk0uIrVYZdTEKAdUwLXWXRF0F10rUYAvLm
y2Sr+I6zQbEOgDKejfa1cBDTjLPtcKeZD/Q9w/8wC43e1yhlppUieAqTZ6JqtFLV
tndeDhiTuA9dE2XCwXscuiFAIuSQ823t4qjnPnYsI0lg3O/7ssEQ5jUrIjT0RNbC
PDT+0ZXIcILqzRJx+Kb0FarHwZSS6t0ztWovS7veo9Cvc8iSXfpfViWGdsecaCtp
o/vqW/X9vG5rzgB4lR2JU27iXz5g8bsDK932PXayzDXCk4CQ3eTqenqfhGTRymle
5jqJISJybyWHckdCdf9QgzHj0er4zSBkc79cGUxsoauTjP2+dMphR7Tkea8Zcji+
7am8PV43Oxz0avtk0sXErG6z7mj5euCiMCUzZLVqvgFKKHJjp/1LJBynLM4gIXTX
DofGQC4Y+Ns7UZo994Kz
=KGS4
-----END PGP SIGNATURE-----

--AonAANj1daC6QcQu--

--===============1456564438==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--===============1456564438==--