From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbaH3WGA (ORCPT ); Sat, 30 Aug 2014 18:06:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54367 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbaH3WF7 (ORCPT ); Sat, 30 Aug 2014 18:05:59 -0400 Date: Sat, 30 Aug 2014 15:05:58 -0700 From: Greg KH To: Miguel Oliveira Cc: devel@driverdev.osuosl.org, Larry.Finger@lwfinger.net, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c Message-ID: <20140830220558.GB15000@kroah.com> References: <1408703558-32167-1-git-send-email-cmroliv@gmail.com> <1408703617-32248-1-git-send-email-cmroliv@gmail.com> <20140830204109.GC16168@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote: > > Same comments as the previous ones, please redo all of these patches. > > > Should all the alterations be in one big single patch, insted of small ones? I don't know, I don't remember what this patch even contained given that it was 100+ patches ago in my review queue and I have the short term memory of a squirrel. Please fix up and resend and I'll be glad to review it then. thanks, greg k-h