From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH 08/10] locks: move i_lock acquisition into generic_*_lease handlers Date: Sun, 31 Aug 2014 10:51:21 -0400 Message-ID: <20140831105121.65086ded@tlielax.poochiereds.net> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> <1408804878-1331-9-git-send-email-jlayton@primarydata.com> <20140824160634.GG15908@infradead.org> <20140824161134.GJ15908@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Return-path: In-Reply-To: <20140824161134.GJ15908-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Sun, 24 Aug 2014 09:11:34 -0700 Christoph Hellwig wrote: > On Sun, Aug 24, 2014 at 09:06:34AM -0700, Christoph Hellwig wrote: > > We really should split a lm_release from lm_change, the way it is > > used is highly confusing. In addition I think a lot of code > > currently in lease_modify should move here instead, e.g. something like: > > At this point the old lm_change actually becomes superflous if we > simply disallow changes for delegation. > This sounds like a reasonable change, but I think it'll be easier to implement a little later once we've done some cleanup and change how file locks are handled. I'm going to leave this out of this current patchset, but I'll keep it in mind for a later cleanup. -- Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-qc0-f182.google.com ([209.85.216.182]:42981 "EHLO mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbaHaOvY (ORCPT ); Sun, 31 Aug 2014 10:51:24 -0400 Received: by mail-qc0-f182.google.com with SMTP id m20so4507700qcx.27 for ; Sun, 31 Aug 2014 07:51:24 -0700 (PDT) From: Jeff Layton Date: Sun, 31 Aug 2014 10:51:21 -0400 To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org, cluster-devel@redhat.com, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 08/10] locks: move i_lock acquisition into generic_*_lease handlers Message-ID: <20140831105121.65086ded@tlielax.poochiereds.net> In-Reply-To: <20140824161134.GJ15908@infradead.org> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> <1408804878-1331-9-git-send-email-jlayton@primarydata.com> <20140824160634.GG15908@infradead.org> <20140824161134.GJ15908@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sun, 24 Aug 2014 09:11:34 -0700 Christoph Hellwig wrote: > On Sun, Aug 24, 2014 at 09:06:34AM -0700, Christoph Hellwig wrote: > > We really should split a lm_release from lm_change, the way it is > > used is highly confusing. In addition I think a lot of code > > currently in lease_modify should move here instead, e.g. something like: > > At this point the old lm_change actually becomes superflous if we > simply disallow changes for delegation. > This sounds like a reasonable change, but I think it'll be easier to implement a little later once we've done some cleanup and change how file locks are handled. I'm going to leave this out of this current patchset, but I'll keep it in mind for a later cleanup. -- Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Date: Sun, 31 Aug 2014 10:51:21 -0400 Subject: [Cluster-devel] [PATCH 08/10] locks: move i_lock acquisition into generic_*_lease handlers In-Reply-To: <20140824161134.GJ15908@infradead.org> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> <1408804878-1331-9-git-send-email-jlayton@primarydata.com> <20140824160634.GG15908@infradead.org> <20140824161134.GJ15908@infradead.org> Message-ID: <20140831105121.65086ded@tlielax.poochiereds.net> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, 24 Aug 2014 09:11:34 -0700 Christoph Hellwig wrote: > On Sun, Aug 24, 2014 at 09:06:34AM -0700, Christoph Hellwig wrote: > > We really should split a lm_release from lm_change, the way it is > > used is highly confusing. In addition I think a lot of code > > currently in lease_modify should move here instead, e.g. something like: > > At this point the old lm_change actually becomes superflous if we > simply disallow changes for delegation. > This sounds like a reasonable change, but I think it'll be easier to implement a little later once we've done some cleanup and change how file locks are handled. I'm going to leave this out of this current patchset, but I'll keep it in mind for a later cleanup. -- Jeff Layton