Re: [alsa-devel] [v3 08/11] ASoC: Intel: sst: add power management handling

From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	lgirdwood@gmail.com
Subject: Re: [alsa-devel] [v3 08/11] ASoC: Intel: sst: add power management handling
Date: Mon, 1 Sep 2014 17:49:59 +0530	[thread overview]
Message-ID: <20140901121959.GE12898@vinod.koul@linux.intel.com> (raw)
In-Reply-To: <20140827204654.GA17528@sirena.org.uk>

On Wed, Aug 27, 2014 at 09:46:54PM +0100, Mark Brown wrote:
> On Thu, Aug 21, 2014 at 06:20:47PM +0530, Subhransu S. Prusty wrote:
> 
> > +	/* When fw_clear_cache is set, clear the cached firmware copy */
> > +	/* fw_clear_cache is set through debugfs support */
> 
> Not in this patch series!
Yes. Will remove.
> 
> > +	if (atomic_read(&ctx->fw_clear_cache) && ctx->fw_in_mem) {
> 
> Why is this an atomic operation?  They're a bit of an alarm bell for
> correctness and it'd seem useful if the clear just happened immediately
> anyway.
> 
> > +	if (ret) {
> > +		pr_err("FW download fail %x\n", ret);
> > +		ctx->sst_state = SST_RESET;
> > +		mutex_unlock(&ctx->sst_lock);
> > +		sst_pm_runtime_put(ctx);
> 
> This is a runtime_pm_put() in the runtime PM callback?  That doesn't
> look right.
Mistakenly added. Not required.


-- 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel