From: chrubis@suse.cz
To: Matus Marhefka <mmarhefk@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] containers: added netns/netns_isolation.sh
Date: Tue, 2 Sep 2014 12:47:18 +0200 [thread overview]
Message-ID: <20140902104718.GA7478@rei.suse.cz> (raw)
In-Reply-To: <1409569423-15376-1-git-send-email-mmarhefk@redhat.com>
Hi!
> +# SETUP
> +tst_require_root
> +which ip &>/dev/null || tst_brkm TCONF "ip utility is required for this test"
> +which ifconfig &>/dev/null ||
> + tst_brkm TCONF "ifconfig utility is required for this test"
We have tst_check_cmds in test.sh exactly for this purpose. And looking
at the code below we only need ifconfig for test case #1, there is no
need to skip the whole test if it's no present.
The rest of the code looks good.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-09-02 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:03 [LTP] [PATCH] containers: added netns/netns_isolation.sh Matus Marhefka
2014-09-02 10:47 ` chrubis [this message]
2014-10-02 14:19 ` [LTP] [PATCH v3] " Matus Marhefka
2014-10-30 9:57 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902104718.GA7478@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=mmarhefk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.