From: Christoph Hellwig <hch@infradead.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/6] NFSD: Put file after ima_file_check fail in nfsd_open()
Date: Tue, 2 Sep 2014 08:57:55 -0700 [thread overview]
Message-ID: <20140902155755.GA14472@infradead.org> (raw)
In-Reply-To: <5405CFE4.9060407@gmail.com>
> + file = dentry_open(&path, flags, current_cred());
> + if (IS_ERR(file)) {
> + host_err = PTR_ERR(file);
> } else {
The is_err case should have a
goto out_nfserr;
which would allow you to drop the following indentation if you
change the whole function anyway.
> if (may_flags & NFSD_MAY_64BIT_COOKIE)
> - (*filp)->f_mode |= FMODE_64BITHASH;
> + (file)->f_mode |= FMODE_64BITHASH;
> else
> - (*filp)->f_mode |= FMODE_32BITHASH;
> + (file)->f_mode |= FMODE_32BITHASH;
no need for the braces around file here.
next prev parent reply other threads:[~2014-09-02 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:10 [PATCH 1/6] NFSD: Put file after ima_file_check fail in nfsd_open() Kinglong Mee
2014-09-02 15:57 ` Christoph Hellwig [this message]
2014-09-03 0:14 ` [PATCH v2] " Kinglong Mee
2014-09-03 0:16 ` [PATCH 1/6] " Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902155755.GA14472@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.