From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
paulus@samba.org
Subject: Re: [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping()
Date: Tue, 2 Sep 2014 20:01:52 -0700 [thread overview]
Message-ID: <20140903030152.GA31420@linux.vnet.ibm.com> (raw)
In-Reply-To: <1409132041-11890-1-git-send-email-zhong@linux.vnet.ibm.com>
On 27.08.2014 [17:33:59 +0800], Li Zhong wrote:
> With commit 2fabf084b6ad ("powerpc: reorder per-cpu NUMA information's
> initialization"), during boottime, cpu_numa_callback() is called
> earlier(before their online) for each cpu, and verify_cpu_node_mapping()
> uses cpu_to_node() to check whether siblings are in the same node.
>
> It skips the checking for siblings that are not online yet. So the only
> check done here is for the bootcpu, which is online at that time. But
> the per-cpu numa_node cpu_to_node() uses hasn't been set up yet (which
> will be set up in smp_prepare_cpus()).
>
> So I saw something like following reported:
> [ 0.000000] CPU thread siblings 1/2/3 and 0 don't belong to the same
> node!
>
> As we don't actually do the checking during this early stage, so maybe
> we could directly call numa_setup_cpu() in do_init_bootmem().
>
> Cc: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
> Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
> ---
> arch/powerpc/mm/numa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index d7737a5..9918c02 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1128,8 +1128,7 @@ void __init do_init_bootmem(void)
> * early in boot, cf. smp_prepare_cpus().
> */
> for_each_possible_cpu(cpu) {
> - cpu_numa_callback(&ppc64_numa_nb, CPU_UP_PREPARE,
> - (void *)(unsigned long)cpu);
> + numa_setup_cpu((unsigned long)cpu);
> }
> }
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-09-03 3:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 9:33 [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping() Li Zhong
2014-08-27 9:34 ` [RFC PATCH v3 2/3] powerpc: Only set numa node information for present cpus at boottime Li Zhong
2014-09-03 3:02 ` Nishanth Aravamudan
2014-09-04 3:53 ` Cyril Bur
2014-08-27 9:34 ` [RFC PATCH v3 3/3] powerpc: some changes in numa_setup_cpu() Li Zhong
2014-09-03 3:04 ` Nishanth Aravamudan
2014-09-03 3:01 ` Nishanth Aravamudan [this message]
2014-10-02 21:13 ` [RFC PATCH v3 1/3] powerpc: Fix warning reported by verify_cpu_node_mapping() Nishanth Aravamudan
2014-10-02 21:28 ` Benjamin Herrenschmidt
2014-10-02 21:53 ` Nishanth Aravamudan
2014-10-02 22:23 ` Benjamin Herrenschmidt
2014-10-03 0:50 ` Michael Ellerman
2014-10-03 23:26 ` Nishanth Aravamudan
2014-10-07 6:28 ` Michael Ellerman
2014-10-07 15:33 ` Nishanth Aravamudan
2014-10-08 4:51 ` Li Zhong
2014-10-14 2:39 ` Li Zhong
2014-10-14 4:35 ` Michael Ellerman
2014-10-15 7:34 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903030152.GA31420@linux.vnet.ibm.com \
--to=nacc@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.