From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212AbaICSEn (ORCPT ); Wed, 3 Sep 2014 14:04:43 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:42082 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbaICSEm convert rfc822-to-8bit (ORCPT ); Wed, 3 Sep 2014 14:04:42 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: Mike Turquette User-Agent: alot/0.3.5 To: Chao Xie , haojian.zhuang@gmail.com, haojian.zhuang@linaro.org, chao.xie@marvell.com, xiechao_mail@163.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1409027904-21859-1-git-send-email-chao.xie@marvell.com> <1409027904-21859-3-git-send-email-chao.xie@marvell.com> In-Reply-To: <1409027904-21859-3-git-send-email-chao.xie@marvell.com> Message-ID: <20140903180424.11368.36053@quantum> Subject: Re: [PATCH 02/12] clk: mmp: add spin lock for clk-frac Date: Wed, 03 Sep 2014 11:04:24 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chao Xie (2014-08-25 21:38:14) > From: Chao Xie > > The register used by clk-frac may be shared with > other clocks. > So it needs to use spin lock to protect the register > access. > > Signed-off-by: Chao Xie This patch will break against the latest clk-next due to api changes. You can see more here[0] and use this script to update your code if you like[1]. Basically the calls to clk_set_rate need to be changed to clk_provider_set_rate. [0] http://lkml.kernel.org/r/<1409758148-20104-1-git-send-email-tomeu.vizoso@collabora.com> [1] http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-9&id=ea48c0d655346cce26329523cf24574f9ea8feee Regards, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH 02/12] clk: mmp: add spin lock for clk-frac Date: Wed, 03 Sep 2014 11:04:24 -0700 Message-ID: <20140903180424.11368.36053@quantum> References: <1409027904-21859-1-git-send-email-chao.xie@marvell.com> <1409027904-21859-3-git-send-email-chao.xie@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1409027904-21859-3-git-send-email-chao.xie@marvell.com> Sender: linux-kernel-owner@vger.kernel.org To: Chao Xie , haojian.zhuang@gmail.com, haojian.zhuang@linaro.orgchao.xie@marvell.com, xiechao_mail@163.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Quoting Chao Xie (2014-08-25 21:38:14) > From: Chao Xie > > The register used by clk-frac may be shared with > other clocks. > So it needs to use spin lock to protect the register > access. > > Signed-off-by: Chao Xie This patch will break against the latest clk-next due to api changes. You can see more here[0] and use this script to update your code if you like[1]. Basically the calls to clk_set_rate need to be changed to clk_provider_set_rate. [0] http://lkml.kernel.org/r/<1409758148-20104-1-git-send-email-tomeu.vizoso@collabora.com> [1] http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-9&id=ea48c0d655346cce26329523cf24574f9ea8feee Regards, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Wed, 03 Sep 2014 11:04:24 -0700 Subject: [PATCH 02/12] clk: mmp: add spin lock for clk-frac In-Reply-To: <1409027904-21859-3-git-send-email-chao.xie@marvell.com> References: <1409027904-21859-1-git-send-email-chao.xie@marvell.com> <1409027904-21859-3-git-send-email-chao.xie@marvell.com> Message-ID: <20140903180424.11368.36053@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Chao Xie (2014-08-25 21:38:14) > From: Chao Xie > > The register used by clk-frac may be shared with > other clocks. > So it needs to use spin lock to protect the register > access. > > Signed-off-by: Chao Xie This patch will break against the latest clk-next due to api changes. You can see more here[0] and use this script to update your code if you like[1]. Basically the calls to clk_set_rate need to be changed to clk_provider_set_rate. [0] http://lkml.kernel.org/r/<1409758148-20104-1-git-send-email-tomeu.vizoso@collabora.com> [1] http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-9&id=ea48c0d655346cce26329523cf24574f9ea8feee Regards, Mike