From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 77/89] drm/i915: Introduce a for_each_plane() macro Date: Thu, 4 Sep 2014 14:32:47 +0100 Message-ID: <20140904133247.GB13230@nuc-i3427.alporthouse.com> References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-78-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E07B6E0E8 for ; Thu, 4 Sep 2014 06:32:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1409830075-11139-78-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 04, 2014 at 12:27:43PM +0100, Damien Lespiau wrote: > Tired of copy/pasting things around. > > v2: Rebase on top of the for_each_pipe() change adding dev_priv as first > argument. > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 91ea2b7..95e57dc 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -176,6 +176,8 @@ enum hpd_pin { > > #define for_each_pipe(__dev_priv, __p) \ > for ((__p) = 0; (__p) < INTEL_INFO(__dev_priv)->num_pipes; (__p)++) > +#define for_each_plane(pipe, p) \ > + for ((p) = 0; (p) < INTEL_INFO(dev)->num_sprites[(pipe)] + 1; (p)++) We are adding new magic macros taking dev... > #define for_each_sprite(p, s) for ((s) = 0; (s) < INTEL_INFO(dev)->num_sprites[(p)]; (s)++) I haven't asked you to fix this one yet either. -Chris -- Chris Wilson, Intel Open Source Technology Centre