From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: TR Reardon <thomas_reardon@hotmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: journal_dev + metadata_csum issues
Date: Sat, 6 Sep 2014 00:13:20 -0700 [thread overview]
Message-ID: <20140906071320.GC27293@birch.djwong.org> (raw)
In-Reply-To: <BAY406-EAS34578C88C7F39934F1D8730FDC50@phx.gbl>
On Thu, Sep 04, 2014 at 12:14:32AM -0400, TR Reardon wrote:
> 1) tune2fs hiccups when presented with journal device fs. Should it instead
> at least report "this is a journal device" rather than "invalid super block"?
Yes. e2fsck/debugfs seem to issue the 'unsupported features' complaint but
without the 'invalid superblock' wording.
> 2) no way to create journal_dev with metadata_csum. This would provide
> checksum for the fs superblock.
Not sure how useful this is since most of the SB is irrelevant here. But I
don't see any reason why we shouldn't let users turn it on.
> 3) dumpe2fs should still display journal flags for journal_dev; currently it
> fails to display journal flags.
Ick. Yes, that should work.
> 4) s_jnl_blocks in the superblock should be zeroed when removing a journal
> (ie ^has_journal) or when setting the journal to journal_dev. Currently, the
> legacy (now dead) block list is maintained. I'd argue that will invite
> misuse.
Seems like a reasonable precaution.
Now, does anyone know why ext4 reports a df size of 64ZB when I create an
external journal FS? :)
--D
prev parent reply other threads:[~2014-09-06 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 4:14 journal_dev + metadata_csum issues TR Reardon
2014-09-06 7:13 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906071320.GC27293@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=thomas_reardon@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.