From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53054)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XQpgC-0003Yk-7D
	for qemu-devel@nongnu.org; Sun, 07 Sep 2014 23:31:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XQpg8-0001y5-9P
	for qemu-devel@nongnu.org; Sun, 07 Sep 2014 23:31:48 -0400
Date: Mon, 8 Sep 2014 13:03:37 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20140908030337.GB4776@voom.redhat.com>
References: <1410134344-30803-1-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW"
Content-Disposition: inline
In-Reply-To: <1410134344-30803-1-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH] spapr: Fix spapr_populate_memory() to
 compile on windows
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>


--b5gNqxB1S1yM7hjW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 08, 2014 at 09:59:04AM +1000, Alexey Kardashevskiy wrote:
> This replaces gcc's ffsl() function ("find first bit set in a word")
> with QEMU's ctzl ("count trailing zeros"). There are no corner cases
> in the affected code so simple replacement ffsl()-1 by ctzl() works.
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Looks sane to me.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--b5gNqxB1S1yM7hjW
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUDRyJAAoJEGw4ysog2bOSQ3AP/jZvSQuJx1jZd4c4mZT10Ajb
9idXIf3pDn9wNaGEihqNDP6hhLVU+H1GUkor2HKle6HkUhIZhUlW96lhOtaXezkG
gR4Mnh5rp+nPEJ270zghSSG7aGvNTLOmIXUEn50VchP8GtnFOoOHP6fsu3BVO2AQ
J1OTcAu5N+5O+SHk2/SMd4Yzs61oX7m7j0rK7d+HC9UfuadLoOlYTr2Unosn15ga
rM7YYf3f49JBPFpimeLNmgmCjvEOQXuVsH1yX/PjDs0KDHJ3YnHCrTugB6wwJt+R
92GLmOxR0X5HOqnvvhWOawsTEVTbnht0JvpEch3iScZ4wLZwPk5DR445KESG+uqs
B+rTMdxzkNMn2tz0bvZyr+z/3OL8IvxB3CthMbwog9eQ8cD0aFjTW+WrQdd0RXit
Vwu7EXDYm40S9nJtEzQqPRkcvOJ3/6HZpdvTTWjQJNQZipIuao4ZiVksJltQ8UOL
UuAdctlJUju5XSgHn4aWCsNHWfvdLzQkYkCR1dbxn681bHecdLlY78B/AXVqtQoo
ywLZfBtVMC9vTVaQg8UmfIDw3p7RQvG9sjQifezZmladT+R+Sy7emQKGF3NJfeic
IDgZqmbjRxK7XZcTW3gDd1kSsVNfngLEzxNpvdY0Oue3DvY17/RGT5WntCFyGMyw
rl4rhzO3Gw271Qxm+nIf
=e3k5
-----END PGP SIGNATURE-----

--b5gNqxB1S1yM7hjW--