From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v9 2/6] clk: Move all drivers to use internal API Date: Sun, 07 Sep 2014 23:13:55 -0700 Message-ID: <20140908061355.19023.47997@quantum> References: <1409758148-20104-2-git-send-email-tomeu.vizoso@collabora.com> <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Tomeu Vizoso Cc: Ulf Hansson , Prashant Gaikwad , "Stephen Warren , Thierry Reding , tomasz.figa@gmail.com, Peter De Schrijver , rabin@rab.in, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Russell King , Shawn Guo , Sascha Hauer , David Brown , Daniel Walker , Bryan Huntsman , Paul Walmsley , Tony Lindgren , =?utf-8?q?=22_Beno=C3=AEt_Cousson?= , Kevin Hilman" , alsa-devel@alsa-project.org List-Id: linux-tegra@vger.kernel.org UXVvdGluZyBUb21ldSBWaXpvc28gKDIwMTQtMDktMDMgMDg6MzE6NTcpCj4gSW4gcHJlcGFyYXRp b24gdG8gY2hhbmdlIHRoZSBwdWJsaWMgQVBJIHRvIHJldHVybiBhIHBlci11c2VyIGNsayBzdHJ1 Y3R1cmUsCj4gcmVtb3ZlIGFueSB1c2FnZSBvZiB0aGlzIHB1YmxpYyBBUEkgZnJvbSB0aGUgY2xv Y2sgaW1wbGVtZW50YXRpb25zLgo+IAo+IFRoZSByZWFzb24gZm9yIGhhdmluZyB0aGlzIGluIGEg c2VwYXJhdGUgY29tbWl0IGZyb20gdGhlIG9uZSB0aGF0IGludHJvZHVjZXMKPiB0aGUgaW1wbGVt ZW50YXRpb24gb2YgdGhlIG5ldyBmdW5jdGlvbnMgaXMgdG8gc2VwYXJhdGUgdGhlIGNoYW5nZXMg Z2VuZXJhdGVkCj4gd2l0aCBDb2NjaW5lbGxlIGZyb20gdGhlIHJlc3QsIGFuZCBrZWVwIHRoZSBw YXRjaGVzJyBzaXplIHJlYXNvbmFibGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogVG9tZXUgVml6b3Nv IDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KPiBUZXN0ZWQtYnk6IEJvcmlzIEJyZXppbGxv biA8Ym9yaXMuYnJlemlsbG9uQGZyZWUtZWxlY3Ryb25zLmNvbT4KPiBUZXN0ZWQtYnk6IEhlaWtv IFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gQWNrZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8 Ym9yaXMuYnJlemlsbG9uQGZyZWUtZWxlY3Ryb25zLmNvbT4KCkhpIFRvbWV1LAoKTG9va3MgbGlr ZSB0aGUgQ29jY2luZWxsZSBzY3JpcHQgaGFkIGEgZmFsc2UtcG9zaXRpdmUuCmFzbS1nZW5lcmlj L2Nsa2Rldi5oIHdhcyBjb252ZXJ0ZWQgZnJvbSBjbGstPmNsa19jb3JlIGFuZCB0aGlzIGJsb3dl ZCB1cApjbG9jayBkcml2ZXJzIGZvciBhcmNoaXRlY3R1cmVzIHRoYXQgZG9uJ3QgcHJvdmlkZSBh biBhc20tc3BlY2lmaWMKY2xrZGV2LmggaW1wbGVtZW50YXRpb24uIFRoaXMgZml4ZXMgeDg2J3Mg TFBTUyBhbmQgYSBNaWNyb2JsYXplIGRyaXZlci4KCkkndmUgcm9sbGVkIHRoZSBmb2xsb3dpbmcg Zml4IGludG8geW91ciAyLzkgcGF0Y2guIE5vIGFjdGlvbiBpcwpuZWNlc3NhcnkuCgpSZWdhcmRz LApNaWtlCgoKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2FzbS1nZW5lcmljL2Nsa2Rldi5oIGIvaW5j bHVkZS9hc20tZ2VuZXJpYy9jbGtkZXYuaAppbmRleCA0MzIwMjI1Li45MGEzMmE2IDEwMDY0NAot LS0gYS9pbmNsdWRlL2FzbS1nZW5lcmljL2Nsa2Rldi5oCisrKyBiL2luY2x1ZGUvYXNtLWdlbmVy aWMvY2xrZGV2LmgKQEAgLTE1LDEwICsxNSwxMCBAQAoKICNpbmNsdWRlIDxsaW51eC9zbGFiLmg+ Cgotc3RydWN0IGNsa19jb3JlOworc3RydWN0IGNsazsKCi1zdGF0aWMgaW5saW5lIGludCBfX2Ns a19nZXQoc3RydWN0IGNsa19jb3JlICpjbGspIHsgcmV0dXJuIDE7IH0KLXN0YXRpYyBpbmxpbmUg dm9pZCBfX2Nsa19wdXQoc3RydWN0IGNsa19jb3JlICpjbGspIHsgfQorc3RhdGljIGlubGluZSBp bnQgX19jbGtfZ2V0KHN0cnVjdCBjbGsgKmNsaykgeyByZXR1cm4gMTsgfQorc3RhdGljIGlubGlu ZSB2b2lkIF9fY2xrX3B1dChzdHJ1Y3QgY2xrICpjbGspIHsgfQoKIHN0YXRpYyBpbmxpbmUgc3Ry dWN0IGNsa19sb29rdXBfYWxsb2MgKl9fY2xrZGV2X2FsbG9jKHNpemVfdCBzaXplKQogewpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYg bWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMu b3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 642C71A00FA for ; Mon, 8 Sep 2014 16:14:12 +1000 (EST) Received: by mail-pa0-f51.google.com with SMTP id kx10so2342192pab.24 for ; Sun, 07 Sep 2014 23:14:09 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Tomeu Vizoso , From: Mike Turquette In-Reply-To: <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> References: <1409758148-20104-2-git-send-email-tomeu.vizoso@collabora.com> <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <20140908061355.19023.47997@quantum> Subject: Re: [PATCH v9 2/6] clk: Move all drivers to use internal API Date: Sun, 07 Sep 2014 23:13:55 -0700 Cc: Ulf Hansson , Prashant Gaikwad , "Stephen Warren , Thierry Reding , tomasz.figa@gmail.com, Peter De Schrijver , rabin@rab.in, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Russell King , Shawn Guo , Sascha Hauer , David Brown , Daniel Walker , Bryan Huntsman , Paul Walmsley , Tony Lindgren , =?utf-8?q?=22_Beno=C3=AEt_Cousson?= , Kevin Hilman" , alsa-devel@alsa-project.org, Jaroslav Kysela , Paul Mackerras , Sylwester Nawrocki , linux-arch@vger.kernel.org, Boris Brezillon , Kukjin Kim , =?utf-8?b?IiBFbWlsaW8gTMOzcGV6?= , patches@opensource.wolfsonmicro.com, Michal Simek , Takashi Iwai , Santosh Shilimkar , Anatolij Gustschin , Dinh Nguyen , linux-media@vger.kernel.org, Arnd Bergmann , linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, Mark Brown , linux-rpi-kernel@lists.infradead.org, Ben Dooks , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Barry Song , Tomeu Vizoso , Liam Girdwood , Kyungmin Park , Viresh Kumar , Maxime Ripard , linuxppc-dev@lists.ozlabs.org, Mauro Carvalho Chehab List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Quoting Tomeu Vizoso (2014-09-03 08:31:57) > In preparation to change the public API to return a per-user clk structur= e, > remove any usage of this public API from the clock implementations. > = > The reason for having this in a separate commit from the one that introdu= ces > the implementation of the new functions is to separate the changes genera= ted > with Coccinelle from the rest, and keep the patches' size reasonable. > = > Signed-off-by: Tomeu Vizoso > Tested-by: Boris Brezillon > Tested-by: Heiko Stuebner > Acked-by: Boris Brezillon Hi Tomeu, Looks like the Coccinelle script had a false-positive. asm-generic/clkdev.h was converted from clk->clk_core and this blowed up clock drivers for architectures that don't provide an asm-specific clkdev.h implementation. This fixes x86's LPSS and a Microblaze driver. I've rolled the following fix into your 2/9 patch. No action is necessary. Regards, Mike diff --git a/include/asm-generic/clkdev.h b/include/asm-generic/clkdev.h index 4320225..90a32a6 100644 --- a/include/asm-generic/clkdev.h +++ b/include/asm-generic/clkdev.h @@ -15,10 +15,10 @@ #include -struct clk_core; +struct clk; -static inline int __clk_get(struct clk_core *clk) { return 1; } -static inline void __clk_put(struct clk_core *clk) { } +static inline int __clk_get(struct clk *clk) { return 1; } +static inline void __clk_put(struct clk *clk) { } static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size) {