From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: FBC flush nuke for BDW
Date: Mon, 8 Sep 2014 09:26:51 +0200
Message-ID: <20140908072651.GK15520@phenom.ffwll.local>
References: <20140804081147.GL8727@phenom.ffwll.local>
 <1407149498-3289-1-git-send-email-rodrigo.vivi@intel.com>
 <CA+gsUGQTbscdr5GY5Pof+b2=hVbjT8rkhJ8dk9XDMSLhVejaiQ@mail.gmail.com>
 <CABVU7+sOhSWosgxvwezu-uikF8qcYSDnjnpkLWgcoooJ2H=TRw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182])
 by gabe.freedesktop.org (Postfix) with ESMTP id 114D86E220
 for <intel-gfx@lists.freedesktop.org>; Mon,  8 Sep 2014 00:26:25 -0700 (PDT)
Received: by mail-we0-f182.google.com with SMTP id w62so14429018wes.13
 for <intel-gfx@lists.freedesktop.org>; Mon, 08 Sep 2014 00:26:25 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CABVU7+sOhSWosgxvwezu-uikF8qcYSDnjnpkLWgcoooJ2H=TRw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Sep 05, 2014 at 12:35:18PM -0700, Rodrigo Vivi wrote:
> On Fri, Sep 5, 2014 at 11:28 AM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > - The screen is disabled
> 
> - We're runtime suspended
> >
> 
> These are another error. Not caused by this patch.
> Why frontbuffer_flush is being called with screen disabled or on runtime
> suspend?

Because the frontbuffer tracking only tells you when a frontbuffer gets
updated. It's the job of the consumers to properly filter these events so
that they only act upon those which are relevant. psr does that, fbc (as
is) doesn't.

And if you have that filtering, adding more filtering as a safeguard
really isn't all that useful.

> > - We're touching cursors when we decide to flush FBC.
> >
> 
> This is not actually a flush. But cleaning the cache to allow compression
> restart.
> I believe we could have some variable to indicate when we touched ring
> flush than on next frontbuffer we do the mmio cache clean.

If you filter frontbuffers properly you can ignore all the cursor/sprite
events completely.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch